-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
go 1.18 make kustomize
fix, GH Actions: go 1.18, submit-coverage fix
#716
go 1.18 make kustomize
fix, GH Actions: go 1.18, submit-coverage fix
#716
Conversation
kustomize v4 can be installed via go install Github Actions: go-test go version bump to 1.18 kustomize v3->v4 breaking changes related to supported url types don't affect our repo
Codecov Report
@@ Coverage Diff @@
## master #716 +/- ##
==========================================
- Coverage 37.27% 37.10% -0.18%
==========================================
Files 14 15 +1
Lines 2940 3099 +159
==========================================
+ Hits 1096 1150 +54
- Misses 1761 1849 +88
- Partials 83 100 +17
Continue to review full report at Codecov.
|
cherrypicking into #710 |
/retest |
@kaovilai: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
@[ -f $(1) ] || { \ | ||
set -e ;\ | ||
TMP_DIR=$$(mktemp -d) ;\ | ||
cd $$TMP_DIR ;\ | ||
go mod init tmp ;\ | ||
echo "Downloading $(2)" ;\ | ||
GOBIN=$(PROJECT_DIR)/bin go get $(2) ;\ | ||
GOBIN=$(PROJECT_DIR)/bin go install -mod=mod $(2) ;\ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a note that -mod=mod
here is required for go 1.16
#716) * Github Actions: go-test go version bump to 1.18 kustomize v4 can be installed via go install Github Actions: go-test go version bump to 1.18 kustomize v3->v4 breaking changes related to supported url types don't affect our repo * -mod=mod
* Update ci-Dockerfile to go 1.19 for oadp-1.0 * remove TODO comment * go 1.18 `make kustomize` fix, GH Actions: go 1.18, submit-coverage fix (#716) * Github Actions: go-test go version bump to 1.18 kustomize v4 can be installed via go install Github Actions: go-test go version bump to 1.18 kustomize v3->v4 breaking changes related to supported url types don't affect our repo * -mod=mod
kustomize v4 can be installed via go install
Github Actions: go-test go version bump to 1.18
kustomize v3->v4 breaking changes related to supported url types don't affect our repo