Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OADP-600: Validate volsync install for data mover #752

Merged
merged 4 commits into from
Jul 19, 2022

Conversation

eemcmullan
Copy link
Contributor

No description provided.

@openshift-ci openshift-ci bot requested a review from kaovilai July 8, 2022 20:16
@dymurray dymurray changed the title Validate volsync install for data mover OADP-552: Validate volsync install for data mover Jul 11, 2022
@eemcmullan
Copy link
Contributor Author

/retest

Copy link
Member

@savitharaghunathan savitharaghunathan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 13, 2022
controllers/datamover.go Outdated Show resolved Hide resolved
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Jul 15, 2022
@openshift-ci
Copy link

openshift-ci bot commented Jul 15, 2022

New changes are detected. LGTM label has been removed.

@kaovilai
Copy link
Member

@kaovilai
Copy link
Member

@eemcmullan
Copy link
Contributor Author

@kaovilai I was not able to add VolSync as a dependency because it is a cluster-scoped operator, and ours is ns scoped

@eemcmullan
Copy link
Contributor Author

/retest

@openshift-ci
Copy link

openshift-ci bot commented Jul 18, 2022

@eemcmullan: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@shubham-pampattiwar shubham-pampattiwar changed the title OADP-552: Validate volsync install for data mover OADP-600: Validate volsync install for data mover Jul 19, 2022
@eemcmullan eemcmullan merged commit 70e4fe5 into openshift:master Jul 19, 2022
@eemcmullan eemcmullan deleted the validate-volsync branch August 30, 2022 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants