pulling in velero upstream changes as of 26 Aug 2022 #809
Conversation
Codecov Report
@@ Coverage Diff @@
## master #809 +/- ##
=======================================
Coverage 31.68% 31.68%
=======================================
Files 16 16
Lines 3080 3080
=======================================
Hits 976 976
Misses 2012 2012
Partials 92 92
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
|
/retest |
|
Looks good to me.. |
|
/LGTM |
| of compute resources allowed. More info: https://kubernetes.io/docs/concepts/configuration/manage-resources-containers/' | ||
| nullable: true | ||
| type: object | ||
| requests: | ||
| additionalProperties: | ||
| anyOf: | ||
| - type: integer | ||
| - type: string | ||
| nullable: true | ||
| pattern: ^(\+|-)?(([0-9]+(\.[0-9]*)?)|(\.[0-9]+))(([KMGTPE]i)|[numkMGTPE]|([eE](\+|-)?(([0-9]+(\.[0-9]*)?)|(\.[0-9]+))))?$ | ||
| x-kubernetes-int-or-string: true |
There was a problem hiding this comment.
Becareful removing nullables here. It's removed when make generate runs I think.
#796 might mitigate this issue.
There was a problem hiding this comment.
@kaovilai Thanks for catching that. I hadn't intended on including this change in the PR. I'll remove it (it's one of the files I have to generally ignore from make bundle since it makes changes even when I didn't touch it.
sseago
force-pushed
the
velero-main-update
branch
from
efc3a74
to
38f6861
Compare
|
New changes are detected. LGTM label has been removed. |
|
/retest |
openshift-merge-robot
added
the
needs-rebase
This includes the first round of kopia-related changes, which may temporarily break things. The most visible change is the renaming of the "resticrepository" CRD to "backuprepository". This also points oadp-operator back to latest velero/plugin images (from 1.9 branches) and updates builder image to latest go version (currently 1.18.4).
sseago
force-pushed
the
velero-main-update
branch
from
38f6861
to
b36cdaf
Compare
openshift-merge-robot
removed
the
needs-rebase
| @@ -1,5 +1,5 @@ | |||
| # Build the manager binary | |||
| FROM quay.io/konveyor/builder:v1.17.2 as builder | |||
| FROM quay.io/konveyor/builder as builder | |||
There was a problem hiding this comment.
Should we be using a tagged version such that it is clear what go version is used?
|
/retest |
|
@sseago: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
From scrum the intention is that openshift:master does not have to be for 1.1.z. We have oadp-1.1 for that. |
|
@kaovilai Yes -- that's what this PR is for. To move oadp-master away from the 1.1 version of velero (1.9.z) and point instead to the main-tracking branch in our fork. |
For new developers it may not be clear why some of the make commands are not working properly. For example [1] changed the minimum required golang to successfully use `make deploy-olm`. It was also not 100% clear what golang version would work across platforms. It may be helpful to specify the required version and expose it via the makefile. [1]openshift#809
This includes the first round of kopia-related changes, which
may temporarily break things.
The most visible change is the renaming of the "resticrepository"
CRD to "backuprepository".
This also points oadp-operator back to latest velero/plugin images (from 1.9 branches)
and updates builder image to latest go version (currently 1.18.4).