[oadp-1.1] Use yq to add nullables to bundle CRD (#796) #813
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaovilai
changed the title
Codecov Report
@@ Coverage Diff @@
## oadp-1.1 #813 +/- ##
===========================================
Coverage ? 31.68%
===========================================
Files ? 16
Lines ? 3080
Branches ? 0
===========================================
Hits ? 976
Misses ? 2012
Partials ? 92 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
sseago
approved these changes
Sep 15, 2022
* remove placeholder deployment, use operator-sdk `--extra-service-accounts`, yq +nullables * use var to shorten yq eval expression
kaovilai
force-pushed
the
oadp-1.1-pr796-cp
branch
from
337dc4c
to
6a06222
Compare
|
/retest |
|
@kaovilai: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
remove placeholder deployment, use operator-sdk
--extra-service-accounts, yq +nullablesuse var to shorten yq eval expression