-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable e2e tests to execute against downstream build #823
Conversation
* Enable e2e tests to execute against downstream build Reusing the e2e tests across upstream and downstream builds will benefit the engineering teams by increasing the coverage across teams. Additionally this should enable QE to execute the dev teams e2e tests against a build. * New Variable = "stream" ( ok name? ) * allow cli -stream or env var OADP_STREAM to set value [up,down] * Only change required was the subscription label Tested and passed on internal build * remove var from Entry
63 char :) |
/retest |
/retest |
2 similar comments
/retest |
/retest |
@@ -353,6 +354,7 @@ test-e2e: test-e2e-setup | |||
--ginkgo.label-filter="$(TEST_FILTER)" \ | |||
-ci_cred_file=$(CI_CRED_FILE) \ | |||
-provider=$(CLUSTER_TYPE) \ | |||
-stream=$(OADP_STREAM) \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was not in #811
Do you want to put this change in master?
https://github.com/openshift/oadp-operator/blob/master/Makefile
/retest |
@hhpatel14: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
/cherry-pick oadp-1.1 |
@kaovilai: #823 failed to apply on top of branch "oadp-1.1":
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
1 similar comment
@kaovilai: #823 failed to apply on top of branch "oadp-1.1":
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@kaovilai: #823 failed to apply on top of branch "master":
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Cherry-pick: 811 Enable e2e tests to execute against downstream build