Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

updating plugin/velero images to use 1.0 branches. #832

Merged
merged 13 commits into from
Sep 26, 2022
Merged

updating plugin/velero images to use 1.0 branches. #832

merged 13 commits into from
Sep 26, 2022

Conversation

sseago
Copy link
Contributor

@sseago sseago commented Sep 23, 2022

No description provided.

@kaovilai
Copy link
Member

Replacing env with RELATED_IMAGE requires velero.go changes
as well as credentials.go changes to update the ENV used.

@kaovilai
Copy link
Member

Missing registry env sseago#5

@sseago
Merge pull request #5 from kaovilai/update-registry-image-env-1.0
9863742 
update RELATED_IMAGE for registry image ENV. CSV name version update.
@sseago
Copy link
Contributor Author

sseago commented Sep 23, 2022

/retest

rayfordj
rayfordj requested changes Sep 23, 2022
View reviewed changes
Copy link
Contributor

@rayfordj rayfordj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Off to a strong start

  • We're already building 1.0.5 images for the next OADP 1.0.z release
  • We're no longer adding 1.0.z to stable; 1.0.3 was the last.
  • The *_test.go files are still using REGISTRY, PROJECT, _REPO, _TAG instead of RELATED_IMAGE_

I realize some of my comments throughout the files are generated using the Makefile, but I wanted to highlight them as I came across them for posterity.

Thanks!

Makefile Outdated Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
bundle/manifests/oadp-operator.clusterserviceversion.yaml Outdated Show resolved Hide resolved
bundle/manifests/oadp-operator.clusterserviceversion.yaml
- name: RELATED_IMAGE_VELERO_PLUGIN_FOR_CSI
value: quay.io/konveyor/velero-plugin-for-csi:oadp-1.0
- name: RELATED_IMAGE_KUBEVIRT_VELERO_PLUGIN
value: quay.io/konveyor/kubevirt-velero-plugin:v0.2.0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

config/manager/manager.yaml
- name: RELATED_IMAGE_VELERO_PLUGIN_FOR_CSI
value: quay.io/konveyor/velero-plugin-for-csi:oadp-1.0
- name: RELATED_IMAGE_KUBEVIRT_VELERO_PLUGIN
value: quay.io/konveyor/kubevirt-velero-plugin:v0.2.0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

controllers/velero_test.go Outdated Show resolved Hide resolved
bundle/manifests/oadp-operator.clusterserviceversion.yaml Outdated Show resolved Hide resolved
kaovilai and others added 7 commits September 23, 2022 19:20
@kaovilai @rayfordj
Makefile version 1.0.5
d63a7d5 
Co-authored-by: RayfordJ <rayfordj@users.noreply.github.com>
@kaovilai @rayfordj
remove stable from CHANNELS Makefile env
6407bd2 
Co-authored-by: RayfordJ <rayfordj@users.noreply.github.com>
@kaovilai @rayfordj
CSV manifest name s/1.0.4/1.0.5/
3ca9478 
Co-authored-by: RayfordJ <rayfordj@users.noreply.github.com>
@kaovilai @rayfordj
CSV .spec.version 1.0.5
a6bdf8a 
Co-authored-by: RayfordJ <rayfordj@users.noreply.github.com>
@kaovilai
Update wantImage and setEnvVars velero_test.go
ad90db7
@kaovilai
update restic to use RELATED_IMAGE_VELERO_RESTIC_RESTORE_HELPER
4464bf4
@kaovilai
update restic_test to use RELATED_IMAGE_VELERO_RESTIC_RESTORE_HELPER
6d89085
@kaovilai
Copy link
Member

kaovilai commented Sep 23, 2022 •
edited

Can't push to remote but can edit one file at a time in web editor :D.
Curious if you have this checked
image

@kaovilai
Copy link
Member

need to update https://github.com/openshift/release/blob/master/ci-operator/config/openshift/oadp-operator/openshift-oadp-operator-oadp-1.0__4.7.yaml#L79 to stable-1.0 to unblock e2e.

@hhpatel14
Copy link
Contributor

need to update https://github.com/openshift/release/blob/master/ci-operator/config/openshift/oadp-operator/openshift-oadp-operator-oadp-1.0__4.7.yaml#L79 to stable-1.0 to unblock e2e.

updating!

@hhpatel14
Copy link
Contributor

openshift/release#32611

@hhpatel14
Copy link
Contributor

/retest

@openshift-ci
Copy link

openshift-ci bot commented Sep 26, 2022

@sseago: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

rayfordj
rayfordj approved these changes Sep 26, 2022
View reviewed changes
Copy link
Contributor

@rayfordj rayfordj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 26, 2022
@kaovilai
Copy link
Member

This PR unblocks oadp-1.0 e2e :) .. let the retests begin :D

@kaovilai kaovilai merged commit f4565d7 into openshift:oadp-1.0 Sep 26, 2022
@kaovilai kaovilai mentioned this pull request Sep 26, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rayfordj rayfordj rayfordj approved these changes

@kaovilai kaovilai kaovilai approved these changes

@savitharaghunathan savitharaghunathan Awaiting requested review from savitharaghunathan

Assignees

@rayfordj rayfordj

Labels
lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@sseago @kaovilai @hhpatel14 @rayfordj