Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

oadp-1.1: OADP-812 Reduce logging after reconciled is reached. #841

Merged
merged 10 commits into from
Oct 5, 2022

Conversation

kaovilai
Copy link
Member

@kaovilai kaovilai commented Sep 29, 2022

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 29, 2022
@openshift-ci
Copy link

openshift-ci bot commented Sep 29, 2022

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@kaovilai kaovilai marked this pull request as ready for review September 29, 2022 17:13
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 29, 2022
@kaovilai kaovilai marked this pull request as draft September 29, 2022 17:27
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 29, 2022
@kaovilai kaovilai marked this pull request as ready for review September 29, 2022 17:55
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 29, 2022
Signed-off-by: Tiger Kaovilai <tkaovila@redhat.com>
@codecov-commenter
Copy link

codecov-commenter commented Sep 29, 2022

Codecov Report

❗ No coverage uploaded for pull request base (oadp-1.1@bd64b19). Click here to learn what that means.
Patch has no changes to coverable lines.

Additional details and impacted files
@@             Coverage Diff             @@
##             oadp-1.1     #841   +/-   ##
===========================================
  Coverage            ?   33.29%           
===========================================
  Files               ?       17           
  Lines               ?     3175           
  Branches            ?        0           
===========================================
  Hits                ?     1057           
  Misses              ?     2026           
  Partials            ?       92           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@kaovilai
Copy link
Member Author

/retest

@kaovilai
Copy link
Member Author

kaovilai commented Oct 3, 2022

/retest
I love testing
/meow

@openshift-ci
Copy link

openshift-ci bot commented Oct 3, 2022

@kaovilai: cat image

In response to this:

/retest
I love testing
/meow

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kaovilai kaovilai changed the title oadp-1.1: OADP-812 Reduce update calls. Implement loglevel override. oadp-1.1: OADP-812 Reduce logging after reconciled is reached. Oct 4, 2022
@kaovilai
Copy link
Member Author

kaovilai commented Oct 4, 2022

/retest
CI * could not run steps: step [release:latest] failed: failed to get CLI image: unable to find the 'cli' image in the provided release image: unable to create pod: timed out waiting for the condition

@kaovilai
Copy link
Member Author

kaovilai commented Oct 4, 2022

  Expected
      <string>: \u00a0\u00a0(\n\u00a0\u00a0\t\"\"\"\n\u00a0\u00a0\t... // 34 identical lines\n\u00a0\u00a0\t1.6649194493083532e+09\tDEBUG\tevents\tNormal\t{\"object\": {\"kind\":\"Service\",\"namespace\":\"openshift-adp\",\"name\":\"openshift-adp-velero-metrics-svc\",\"uid\":\"abef7c3e-4888-405f-924e-18cf14a1f3c1\",\"apiVersion\":\"v1\",\"resourceVersion\":\"29097\"}, \"reason\": \"VeleroMetricsServiceReconciled\", \"message\": \"performed created on dpa metrics service openshift-adp/openshift-adp-velero-metrics-svc\"}\n\u00a0\u00a0\t1.664919449368483e+09\tINFO\tcontroller.dataprotectionapplication\tAzure secret name: bsl-cloud-credentials-azure and secret key: cloud\t{\"reconciler group\": \"oadp.openshift.io\", \"reconciler kind\": \"DataProtectionApplication\", \"name\": \"ts-velero-test\", \"namespace\": \"openshift-adp\"}\n+\u00a0\t1.6649194785535486e+09\tINFO\tcontroller.dataprotectionapplication\tAzure secret name: bsl-cloud-credentials-azure and secret key: cloud\t{\"reconciler group\": \"oadp.openshift.io\", \"reconciler kind\": \"DataProtectionApplication\", \"name\": \"ts-velero-test\", \"namespace\": \"openshift-adp\"}\n+\u00a0\t1.6649194785807037e+09\tINFO\tcontroller.dataprotectionapplication\tAzure secret name: bsl-cloud-credentials-azure and secret key: cloud\t{\"reconciler group\": \"oadp.openshift.io\", \"reconciler kind\": \"DataProtectionApplication\", \"name\": \"ts-velero-test\", \"namespace\": \"openshift-adp\"}\n\u00a0\u00a0\t\"\"\"\n\u00a0\u00a0)\n
  to equal
      <string>: 
  In [It] at: /go/src/github.com/openshift/oadp-operator/tests/e2e/dpa_deployment_suite_test.go:666

@kaovilai
Copy link
Member Author

kaovilai commented Oct 5, 2022

/retest

1 similar comment
@kaovilai
Copy link
Member Author

kaovilai commented Oct 5, 2022

/retest

@openshift-ci
Copy link

openshift-ci bot commented Oct 5, 2022

@kaovilai: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@kaovilai kaovilai merged commit c45823d into openshift:oadp-1.1 Oct 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants