-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OADP-823: Address oadp-1.0.z with ocp 4.11 csi compatibility issue #848
OADP-823: Address oadp-1.0.z with ocp 4.11 csi compatibility issue #848
Conversation
looks good to me.. I suspect we should add a unit test for this issue. Should be easy enough and can be in a follow up. |
/LGTM |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please don't do
for _, plugin := range dpa.Spec.Configuration.Velero.DefaultPlugins {
for _, plugin := range dpa.Spec.Configuration.Velero.DefaultPlugins {
}
}
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agree with Emily on condensing error string a bit. otherwise
/lgtm
New changes are detected. LGTM label has been removed. |
@shubham-pampattiwar: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
No description provided.