Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

master: ci: Ensure go mod matches ginkgo bin installed #854

Merged
merged 2 commits into from
Oct 14, 2022
Merged

master: ci: Ensure go mod matches ginkgo bin installed #854

merged 2 commits into from
Oct 14, 2022

Conversation

kaovilai
Copy link
Member

@kaovilai kaovilai commented Oct 12, 2022 •
edited
Loading

Verify in gitpod environment. https://gitpod.io/#https://github.com/kaovilai/oadp-operator/tree/master-ginkgo-ciDockerfile-graceperiod

gitpod /workspace/oadp-operator (master-ginkgo-ciDockerfile-graceperiod) $ docker build -f build/ci-Dockerfile . -t cidockerfile
Sending build context to Docker daemon  67.31MB
gitpod /workspace/oadp-operator (master-ginkgo-ciDockerfile-graceperiod) $ docker run -it --rm cidockerfile
[root@f3ec4e0f5fa0 oadp-operator]# /root/go/bin/ginkgo version
Ginkgo Version 2.3.0
[root@f3ec4e0f5fa0 oadp-operator]# cat go.mod | grep ginkgo/v2
        github.com/onsi/ginkgo/v2 v2.3.0

Per onsi/ginkgo#1055

Fixes #851 (comment)

@kaovilai
Copy link
Member Author

/retest

1 similar comment
@kaovilai
Copy link
Member Author

/retest

@kaovilai kaovilai mentioned this pull request Oct 13, 2022
Merged
rayfordj
rayfordj approved these changes Oct 13, 2022
View reviewed changes
Copy link
Contributor

@rayfordj rayfordj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 13, 2022
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Oct 13, 2022
rayfordj
rayfordj approved these changes Oct 13, 2022
View reviewed changes
Copy link
Contributor

@rayfordj rayfordj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 13, 2022
@openshift-ci
Copy link

openshift-ci bot commented Oct 13, 2022

@kaovilai: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@kaovilai kaovilai merged commit 1d6d8af into openshift:master Oct 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rayfordj rayfordj rayfordj approved these changes

@savitharaghunathan savitharaghunathan Awaiting requested review from savitharaghunathan

@shubham-pampattiwar shubham-pampattiwar Awaiting requested review from shubham-pampattiwar

Assignees

@rayfordj rayfordj

Labels
lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kaovilai @rayfordj