-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
oadp-1.1: yq format when for make test
. pin gomega to v1.22
#859
Conversation
Codecov ReportBase: 32.65% // Head: 32.65% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## oadp-1.1 #859 +/- ##
=========================================
Coverage 32.65% 32.65%
=========================================
Files 17 17
Lines 3237 3237
=========================================
Hits 1057 1057
Misses 2088 2088
Partials 92 92 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
/retest |
build/custom-ci-Dockerfile
Outdated
@@ -1,8 +1,9 @@ | |||
FROM openshift/origin-release:golang-1.16 | |||
FROM openshift/origin-release:golang-1.17 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
note that this image tag golang-1.17
doesn't actually exists at least in docker hub.
Will check and maybe remove this file if it's not used anywhere.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will delete in a follow up later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks to be a leftover from ansible days
/retest |
1 similar comment
/retest |
make test
. pin gomega to v1.22
Do we want this change on OADP-1.1.1 ? |
Let's punt for 1.1.2 |
…penshift#846) * Makefile automate operator-sdk installation * pin yq to 4.28.1 for go 1.17 * Preserve DPA nullables for `make test` Signed-off-by: Tiger Kaovilai <tkaovila@redhat.com> Signed-off-by: Tiger Kaovilai <tkaovila@redhat.com>
2eee73d
to
a8325fa
Compare
@kaovilai: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Cherrypick #846 to oadp-1.1