-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OADP-694 oadp-1.1: Add data mover to e2e #863
Conversation
Signed-off-by: Tiger Kaovilai <tkaovila@redhat.com> override images comment image overrides Use 1.1 images + emcmulla/csi-plugin:latest Signed-off-by: Tiger Kaovilai <tkaovila@redhat.com>
Codecov ReportBase: 32.65% // Head: 32.65% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## oadp-1.1 #863 +/- ##
=========================================
Coverage 32.65% 32.65%
=========================================
Files 17 17
Lines 3237 3237
=========================================
Hits 1057 1057
Misses 2088 2088
Partials 92 92 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
4.9 aws succeeded. /retest |
/retest |
2 similar comments
/retest |
/retest |
Signed-off-by: Tiger Kaovilai <tkaovila@redhat.com>
a96db3e
to
458a792
Compare
/retest |
Signed-off-by: Tiger Kaovilai <tkaovila@redhat.com>
5c85335
to
29f8718
Compare
/retest |
/retest |
/test 4.10-operator-e2e-azure |
42ac489
to
213fb9e
Compare
@@ -186,7 +261,7 @@ var _ = Describe("AWS backup restore tests", func() { | |||
Expect(err).ToNot(HaveOccurred()) | |||
|
|||
// wait for backup to not be running | |||
Eventually(IsBackupDone(dpaCR.Client, namespace, backupName), timeoutMultiplier*time.Minute*12, time.Second*10).Should(BeTrue()) | |||
Eventually(IsBackupDone(dpaCR.Client, namespace, backupName), timeoutMultiplier*time.Minute*20, time.Second*10).Should(BeTrue()) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since this is data mover test, would it be possible to also check if VSB is completed here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Velero backup status should be reliable. VSB status should really only rarely be checked when things go wrong.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's leave it out. Could add on failure. Follow up todo?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually VSB/VSR is already checked on failure
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
*logged on failure.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds good
// run restore | ||
log.Printf("Creating restore %s for case %s", restoreName, brCase.Name) | ||
restore, err := CreateRestoreFromBackup(dpaCR.Client, namespace, backupName, restoreName) | ||
Expect(err).ToNot(HaveOccurred()) | ||
Eventually(IsRestoreDone(dpaCR.Client, namespace, restoreName), timeoutMultiplier*time.Minute*4, time.Second*10).Should(BeTrue()) | ||
Eventually(IsRestoreDone(dpaCR.Client, namespace, restoreName), timeoutMultiplier*time.Minute*60, time.Second*10).Should(BeTrue()) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same here for VSR
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually VSB/VSR is already checked on failure
Signed-off-by: Tiger Kaovilai <tkaovila@redhat.com>
213fb9e
to
f19a66c
Compare
/test 4.9-operator-e2e-gcp |
/retest |
Signed-off-by: Tiger Kaovilai <tkaovila@redhat.com>
@@ -171,14 +193,26 @@ func (v *DpaCustomResource) CreateOrUpdateWithRetries(spec *oadpv1alpha1.DataPro | |||
) | |||
for i := 0; i < retries; i++ { | |||
if cr, err = v.Get(); apierrors.IsNotFound(err) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
was there repeated errors creating the dpa here or is this just an improvement?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ensuring the content of v.CustomResource that's all.
return buf.String(), nil | ||
} | ||
|
||
func GetDeploymentPodContainerLogs(namespace, deploymentName, containerName string) (string, error) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh snap.. am I reading the correctly? We have to verify the that restore worked w/ datamover by scraping the deployment log?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's used here in case of failure for dumping out logs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks awesome but I do have some questions
GinkgoWriter.Println("Printing volume-snapshot-mover deployment pod logs") | ||
GinkgoWriter.Print(GetDeploymentPodContainerLogs(namespace, common.DataMover, common.DataMoverControllerContainer)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we get some code comments as to why we're pulling the log
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please add code comments as to why
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
spoke to Tiger about a few things, will land improvements in jira. Approved well done!
@kaovilai: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
@@ -186,7 +261,7 @@ var _ = Describe("AWS backup restore tests", func() { | |||
Expect(err).ToNot(HaveOccurred()) | |||
|
|||
// wait for backup to not be running | |||
Eventually(IsBackupDone(dpaCR.Client, namespace, backupName), timeoutMultiplier*time.Minute*12, time.Second*10).Should(BeTrue()) | |||
Eventually(IsBackupDone(dpaCR.Client, namespace, backupName), timeoutMultiplier*time.Minute*20, time.Second*10).Should(BeTrue()) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds good
err = dpaCR.Client.List(context.Background(), &pvcList, &client.ListOptions{Namespace: namespace}) | ||
Expect(err).NotTo(HaveOccurred()) | ||
GinkgoWriter.Printf("PVC oadp ns list %v\n", pvcList) | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Worth listing volumeSnapshotContents? wdyt
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure
/cherry-pick master |
@hhpatel14: #863 failed to apply on top of branch "master":
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Co-authored-by: Tiger Kaovilai <tiger+github@redhat.com>
* master: Add data mover to e2e cherrypick of #863 Co-authored-by: Tiger Kaovilai <tiger+github@redhat.com> * workaround to fix existing PVC of the same name found.. Signed-off-by: Tiger Kaovilai <tkaovila@redhat.com> * 1.2 update * add restorePhase async plugin waiting phases Signed-off-by: Tiger Kaovilai <tkaovila@redhat.com> * Remove duplicate application installs, add CSIDataMover failure deletion handling, volsync channel stable-0.7 Signed-off-by: Tiger Kaovilai <tkaovila@redhat.com> * Create app, and therefore namespace, before creating PVC into namespace Signed-off-by: Tiger Kaovilai <tkaovila@redhat.com> * FEntry typo Signed-off-by: Tiger Kaovilai <tkaovila@redhat.com> * enable volsync MoverSecurityContext Signed-off-by: Tiger Kaovilai <tkaovila@redhat.com> * Update mysql/mariadb pod securityContext to match Dockerfile USER for volsync to pick up. Signed-off-by: Tiger Kaovilai <tkaovila@redhat.com> * add vsmv1alpha1 to client scheme for failure cleanup Signed-off-by: Tiger Kaovilai <tkaovila@redhat.com> --------- Signed-off-by: Tiger Kaovilai <tkaovila@redhat.com> Co-authored-by: Tiger Kaovilai <tkaovila@redhat.com> Co-authored-by: Tiger Kaovilai <tiger+github@redhat.com>
Co-authored-by: Tiger Kaovilai <tiger+github@redhat.com>
* master: Add data mover to e2e cherrypick of #863 Co-authored-by: Tiger Kaovilai <tiger+github@redhat.com> * workaround to fix existing PVC of the same name found.. Signed-off-by: Tiger Kaovilai <tkaovila@redhat.com> * 1.2 update * add restorePhase async plugin waiting phases Signed-off-by: Tiger Kaovilai <tkaovila@redhat.com> * Remove duplicate application installs, add CSIDataMover failure deletion handling, volsync channel stable-0.7 Signed-off-by: Tiger Kaovilai <tkaovila@redhat.com> * Create app, and therefore namespace, before creating PVC into namespace Signed-off-by: Tiger Kaovilai <tkaovila@redhat.com> * FEntry typo Signed-off-by: Tiger Kaovilai <tkaovila@redhat.com> * enable volsync MoverSecurityContext Signed-off-by: Tiger Kaovilai <tkaovila@redhat.com> * Update mysql/mariadb pod securityContext to match Dockerfile USER for volsync to pick up. Signed-off-by: Tiger Kaovilai <tkaovila@redhat.com> * add vsmv1alpha1 to client scheme for failure cleanup Signed-off-by: Tiger Kaovilai <tkaovila@redhat.com> --------- Signed-off-by: Tiger Kaovilai <tkaovila@redhat.com> Co-authored-by: Tiger Kaovilai <tkaovila@redhat.com> Co-authored-by: Tiger Kaovilai <tiger+github@redhat.com> Co-authored-by: hhpatel14 <hitpatel@redhat.com>
Signed-off-by: Tiger Kaovilai tkaovila@redhat.com
override images
comment image overrides
Use 1.1 images + emcmulla/csi-plugin:latest
Signed-off-by: Tiger Kaovilai tkaovila@redhat.com