Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OADP-1015 Two volume backup-restore E2E-test #864

Merged
merged 1 commit into from
Nov 21, 2022

Conversation

hhpatel14
Copy link
Contributor

No description provided.

@hhpatel14 hhpatel14 changed the title Two volume backup-restore E2E-test [WIP] Two volume backup-restore E2E-test Nov 15, 2022
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 15, 2022
@weshayutin weshayutin self-requested a review November 15, 2022 02:31
@codecov-commenter
Copy link

codecov-commenter commented Nov 15, 2022

Codecov Report

Base: 33.79% // Head: 33.79% // No change to project coverage 👍

Coverage data is based on head (9c27a1c) compared to base (7813e83).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #864   +/-   ##
=======================================
  Coverage   33.79%   33.79%           
=======================================
  Files          17       17           
  Lines        3128     3128           
=======================================
  Hits         1057     1057           
  Misses       1979     1979           
  Partials       92       92           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@hhpatel14
Copy link
Contributor Author

/test 4.11-operator-e2e-aws

@hhpatel14
Copy link
Contributor Author

/test 4.9-operator-e2e-azure

tests/e2e/lib/apps.go Outdated Show resolved Hide resolved
tests/e2e/lib/apps.go Outdated Show resolved Hide resolved
@weshayutin
Copy link
Contributor

Nice.. and i can see the output and check in the log
https://gcsweb-ci.apps.ci.l2s4.p1.openshiftapps.com/gcs/origin-ci-test/pr-logs/pull/openshift_oadp-operator/864/pull-ci-openshift-oadp-operator-master-4.10-operator-e2e-aws/1592973211421642752/artifacts/operator-e2e-aws/e2e/build-log.txt

2022/11/16 21:08:17 Creating restore mysql-twovol-csi-e2e-6fc55c18-65f2-11ed-932c-0a580a833d07 for case mysql-twovol-csi-e2e
checking for the NAMESPACE: mysql-persistent
 2022/11/16 21:08:33 Running post-restore function for case mysql-twovol-csi-e2e
2022/11/16 21:08:33 Verifying backup/restore data of todolist
I1116 21:08:34.800956   16561 request.go:601] Waited for 1.000655326s due to client-side throttling, not priority and fairness, request: GET:https://api.ci-op-iqpf4ljb-6ffd2.origin-ci-int-aws.dev.rhcloud.com:6443/apis/coordination.k8s.io/v1?timeout=32s
2022/11/16 21:08:36 Request error: <nil>
2022/11/16 21:08:36 Retrying in 15s
Data came from backup-file
 [{"Id":1,"Description":"time to make the donuts","Completed":false},{"Id":3,"Description":"2022-11-16 21:06:19.429278189 +0000 UTC m=+1088.748385329","Completed":false},{"Id":4,"Description":"Wednesday","Completed":false}]

Data from the response after restore
 [{"Id":1,"Description":"time to make the donuts","Completed":false},{"Id":3,"Description":"2022-11-16 21:06:19.429278189 +0000 UTC m=+1088.748385329","Completed":false},{"Id":4,"Description":"Wednesday","Completed":false}]

Data came from volume-file
 time="2022-11-16T21:06:09Z" level=info msg="Success: Attached volume and redirected logs to /tmp/log/todoapp/app.log" func=main.main file="/build/todolist.go:179"
time="2022-11-16T21:06:09Z" level=info msg="A running instance of the db: todolist not found, creating" func=main.main file="/build/todolist.go:185"
time="2022-11-16T21:06:09Z" level=info msg="Prepopulate the db" func=main.prepopulate file="/build/todolist.go:152"
time="2022-11-16T21:06:09Z" level=info msg="Starting Todolist API server" func=main.main file="/build/todolist.go:193"
time="2022-11-16T21:06:19Z" level=info msg="Get Incomplete TodoItems" func=main.GetIncompleteItems file="/build/todolist.go:120"
time="2022-11-16T21:06:19Z" level=info msg="Get Incomplete TodoItems" func=main.GetIncompleteItems file="/build/todolist.go:120"
time="2022-11-16T21:06:19Z" level=info msg="Add new TodoItem. Saving to database." func=main.CreateItem file="/build/todolist.go:52" description="2022-11-16 21:06:19.429278189 +0000 UTC m=+1088.748385329"
time="2022-11-16T21:06:19Z" level=info msg="Add new TodoItem. Saving to database." func=main.CreateItem file="/build/todolist.go:52" description=Wednesday
time="2022-11-16T21:06:19Z" level=info msg="Get Incomplete TodoItems" func=main.GetIncompleteItems file="/build/todolist.go:120"

Volume Data after restore
 time="2022-11-16T21:06:09Z" level=info msg="Success: Attached volume and redirected logs to /tmp/log/todoapp/app.log" func=main.main file="/build/todolist.go:179"
time="2022-11-16T21:06:09Z" level=info msg="A running instance of the db: todolist not found, creating" func=main.main file="/build/todolist.go:185"
time="2022-11-16T21:06:09Z" level=info msg="Prepopulate the db" func=main.prepopulate file="/build/todolist.go:152"
time="2022-11-16T21:06:09Z" level=info msg="Starting Todolist API server" func=main.main file="/build/todolist.go:193"
time="2022-11-16T21:06:19Z" level=info msg="Get Incomplete TodoItems" func=main.GetIncompleteItems file="/build/todolist.go:120"
time="2022-11-16T21:06:19Z" level=info msg="Get Incomplete TodoItems" func=main.GetIncompleteItems file="/build/todolist.go:120"
time="2022-11-16T21:06:19Z" level=info msg="Add new TodoItem. Saving to database." func=main.CreateItem file="/build/todolist.go:52" description="2022-11-16 21:06:19.429278189 +0000 UTC m=+1088.748385329"
time="2022-11-16T21:06:19Z" level=info msg="Add new TodoItem. Saving to database." func=main.CreateItem file="/build/todolist.go:52" description=Wednesday
time="2022-11-16T21:06:19Z" level=info msg="Get Incomplete TodoItems" func=main.GetIncompleteItems file="/build/todolist.go:120"
time="2022-11-16T21:08:41Z" level=info msg="Success: Attached volume and redirected logs to /tmp/log/todoapp/app.log" func=main.main file="/build/todolist.go:179"
time="2022-11-16T21:08:41Z" level=info msg="Starting Todolist API server" func=main.main file="/build/todolist.go:193"
time="2022-11-16T21:08:51Z" level=info msg="Get Incomplete TodoItems" func=main.GetIncompleteItems file="/build/todolist.go:120"
time="2022-11-16T21:08:51Z" level=info msg="Get Incomplete TodoItems" func=main.GetIncompleteItems file="/build/todolist.go:120"
time="2022-11-16T21:08:51Z" level=info msg="Get Incomplete TodoItems" func=main.GetIncompleteItems file="/build/todolist.go:120"

@weshayutin weshayutin changed the title [WIP] Two volume backup-restore E2E-test OADP-1015 Two volume backup-restore E2E-test Nov 17, 2022
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 17, 2022
@hhpatel14
Copy link
Contributor Author

/test 4.11-operator-e2e-gcp

@hhpatel14
Copy link
Contributor Author

/test 4.11-operator-e2e-azure

@openshift-ci
Copy link

openshift-ci bot commented Nov 17, 2022

@hhpatel14: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Copy link
Contributor

@weshayutin weshayutin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! thank you

Copy link
Member

@kaovilai kaovilai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we just need two volumes in backup then LGTM. Otherwise do we need in either deploymentconfig or deployment to have two volumes?

@kaovilai kaovilai merged commit 6d03d45 into openshift:master Nov 21, 2022
@kaovilai
Copy link
Member

/cherry-pick oadp-1.1

@openshift-cherrypick-robot
Copy link
Contributor

@kaovilai: #864 failed to apply on top of branch "oadp-1.1":

Applying: Two volume backup-restore E2E-test
Using index info to reconstruct a base tree...
M	tests/e2e/backup_restore_suite_test.go
M	tests/e2e/lib/apps.go
Falling back to patching base and 3-way merge...
Auto-merging tests/e2e/lib/apps.go
Auto-merging tests/e2e/backup_restore_suite_test.go
CONFLICT (content): Merge conflict in tests/e2e/backup_restore_suite_test.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 Two volume backup-restore E2E-test
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherry-pick oadp-1.1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

kaovilai pushed a commit to kaovilai/oadp-operator that referenced this pull request Nov 21, 2022
kaovilai added a commit to kaovilai/oadp-operator that referenced this pull request Nov 21, 2022
kaovilai added a commit that referenced this pull request Nov 23, 2022
… mover (#870)

* Two volume backup-restore E2E-test (#864)

* mod datamover e2e for twovol

Signed-off-by: Tiger Kaovilai <tkaovila@redhat.com>
Co-authored-by: Hiteshwari Patel <hitpatel@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants