Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

oadp-1.1: OADP-1150 Add Env to dpa.Spec.PodConfig #886

Merged
merged 1 commit into from
Jan 30, 2023

Conversation

kaovilai
Copy link
Member

@kaovilai kaovilai commented Jan 25, 2023

Makes Velero and Restic pods Environment variables configurable.

OADP-1150

@codecov-commenter
Copy link

Codecov Report

Base: 33.54% // Head: 33.45% // Decreases project coverage by -0.09% ⚠️

Coverage data is based on head (8dbcec1) compared to base (0204698).
Patch coverage: 35.48% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff              @@
##           oadp-1.1     #886      +/-   ##
============================================
- Coverage     33.54%   33.45%   -0.09%     
============================================
  Files            17       17              
  Lines          3151     3171      +20     
============================================
+ Hits           1057     1061       +4     
- Misses         2002     2018      +16     
  Partials         92       92              
Impacted Files Coverage Δ
pkg/common/common.go 42.42% <0.00%> (-39.93%) ⬇️
controllers/velero.go 57.22% <60.00%> (+0.23%) ⬆️
controllers/restic.go 52.38% <100.00%> (+0.18%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@kaovilai kaovilai changed the title OADP-1150 Add Env to dpa.Spec.PodConfig oadp-1.1: OADP-1150 Add Env to dpa.Spec.PodConfig Jan 25, 2023
@kaovilai
Copy link
Member Author

/retest

1 similar comment
@kaovilai
Copy link
Member Author

/retest

@kaovilai
Copy link
Member Author

2023/01/26 20:42:03 command: /usr/bin/bash /go/src/github.com/openshift/oadp-operator/docs/scripts/dc-restic-post-restore.sh mysql-restic-e2e-836a8451-9db9-11ed-9210-0a580a8022d5
2023/01/26 20:42:03 stdout: using OADP Namespace openshift-adp
restore: mysql-restic-e2e-836a8451-9db9-11ed-9210-0a580a8022d5
label: mysql-restic-e2e-836a8451-9db9-11ed-9210-0a580a8022d5
Deleting disconnected restore pods
2023/01/26 20:42:03 stderr: &{%!s(int=32768) Unable to connect to the server: dial tcp 20.109.240.162:6443: i/o timeout

/retest

@kaovilai
Copy link
Member Author

/retest

@openshift-ci
Copy link

openshift-ci bot commented Jan 27, 2023

@kaovilai: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@kaovilai kaovilai merged commit 3c0f877 into openshift:oadp-1.1 Jan 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants