-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug 1872080: Updating images/Dockerfile.rhel baseimages to mach ocp-build-data config #51
Conversation
@openshift-bot: This pull request references Bugzilla bug 1872080, which is valid. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/retest |
/hold |
/retest |
1 similar comment
/retest |
/lgtm |
With 1.15 there will be a new PR switching this to explicit versions, with an option to opt-out by holding that. /hold cancel |
/retest Please review the full test history for this PR and help us cut down flakes. |
5 similar comments
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
This PR is autogenerated by the [ocp-build-data-enforcer][1]. It updates the baseimages in the Dockerfile used for promotion in order to ensure it matches the configuration in the [ocp-build-data repository][2] used for producing release artifacts. If you believe the content of this PR is incorrect, please contact the dptp team in #forum-testplatform. [1]: https://github.com/openshift/ci-tools/tree/master/cmd/ocp-build-data-enforcer [2]: https://github.com/openshift/ocp-build-data/tree/openshift-4.6-rhel-8/images
d982c09
to
bd9d26e
Compare
2c2
< index b5255471..442e3e3e 100644
---
> index 641398a3..442e3e3e 100644
5,6c5,6
< @@ -1,10 +1,10 @@
< -FROM registry.svc.ci.openshift.org/ocp/builder:golang-1.13 AS builder
---
> @@ -1,4 +1,4 @@
> -FROM registry.svc.ci.openshift.org/ocp/builder:golang-1.14 AS builder
11,17d10
< RUN make build --warn-undefined-variables
<
< -FROM registry.svc.ci.openshift.org/ocp/4.2:base
< +FROM registry.svc.ci.openshift.org/ocp/4.6:base
< COPY --from=builder /go/src/github.com/openshift/oauth-server/oauth-server /usr/bin/
< ENTRYPOINT ["/usr/bin/oauth-server"]
< LABEL io.k8s.display-name="OpenShift OAuth Server" \ I'm going to re-add the lgtm label since there weren't any real changes after the last /lgtm; just a rebase. /lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: crawford, openshift-bot, stlaz The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest Please review the full test history for this PR and help us cut down flakes. |
This PR is autogenerated by the ocp-build-data-enforcer.
It updates the baseimages in the Dockerfile used for promotion in order to ensure it
matches the configuration in the ocp-build-data repository used
for producing release artifacts.
If you believe the content of this PR is incorrect, please contact the dptp team in
#forum-testplatform.