Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

oc-mirror skip-missing still returns a 404 error #476

Closed
jpower432 opened this issue May 24, 2022 · 1 comment · Fixed by #484
Closed

oc-mirror skip-missing still returns a 404 error #476

jpower432 opened this issue May 24, 2022 · 1 comment · Fixed by #484
Assignees
Labels
kind/bug Categorizes issue or PR as related to a bug.
Milestone

Comments

@jpower432
Copy link
Contributor

jpower432 commented May 24, 2022

Version

$ oc-mirror version
Client Version: version.Info{Major:"", Minor:"", GitVersion:"v0.2.0-alpha.1-42-ge3e6bf9", GitCommit:"e3e6bf9f", GitTreeState:"clean", BuildDate:"2022-05-24T17:31:23Z", GoVersion:"go1.17.1", Compiler:"gc", Platform:"linux/amd64"}

What happened?

error parsing HTTP 404 response body: invalid character 'N' looking for beginning of value: "Not found\n"

What did you expect to happen?

No 404 error with skip-missing

How to reproduce it (as minimally and precisely as possible)?

apiVersion: mirror.openshift.io/v1alpha2
kind: ImageSetConfiguration
storageConfig:
  local:
    path: metadata
mirror:
  operators:
    - catalog: registry.redhat.io/redhat/redhat-operator-index:v4.10
      packages:
        - name: ptp-operator
          channels:
            - name: stable
          minVersion: '4.10.0-202205121158'
$ oc-mirror --config ~/configs/imageset-config.yaml docker://localhost:5001 --skip-missing

Anything else we need to know?

This happens because oc-mirror translates all tag references to digest and the library used to mirror supports tag references only currently.

References

openshift/oc#1105

https://bugzilla.redhat.com/show_bug.cgi?id=2089918

@jpower432 jpower432 added this to the Release-4.11 milestone May 24, 2022
@jpower432 jpower432 added this to To do in Priority Backlog via automation May 24, 2022
@jpower432 jpower432 added the kind/bug Categorizes issue or PR as related to a bug. label May 24, 2022
@jpower432
Copy link
Contributor Author

Waiting on PR operator-framework/operator-registry#964 to resolve dependency conflict between the oc import and operator-registry import.

@jpower432 jpower432 moved this from To do to In progress in Priority Backlog May 31, 2022
jpower432 added a commit to jpower432/bundle that referenced this issue Jun 2, 2022
Fixes openshift#476

Signed-off-by: Jennifer Power <barnabei.jennifer@gmail.com>
jpower432 added a commit to jpower432/bundle that referenced this issue Jun 2, 2022
Fixes openshift#476

Signed-off-by: Jennifer Power <barnabei.jennifer@gmail.com>
@jpower432 jpower432 self-assigned this Jun 2, 2022
jpower432 added a commit to jpower432/bundle that referenced this issue Jun 6, 2022
Fixes openshift#476

Signed-off-by: Jennifer Power <barnabei.jennifer@gmail.com>
jpower432 added a commit to jpower432/bundle that referenced this issue Jun 7, 2022
Fixes openshift#476

Signed-off-by: Jennifer Power <barnabei.jennifer@gmail.com>
jpower432 added a commit to jpower432/bundle that referenced this issue Jun 8, 2022
Fixes openshift#476

Signed-off-by: Jennifer Power <barnabei.jennifer@gmail.com>
Priority Backlog automation moved this from In progress to Done Jun 10, 2022
openshift-merge-robot pushed a commit that referenced this issue Jun 10, 2022
* chore(dep): bumps dependencey versions

bumps oc import version to commit d91e0087a8a6120cbbea65397d25267a8de1cf42

bumps operator-registry import to v1.23.0

bumos helm import version to v3.9.0

Signed-off-by: Jennifer Power <barnabei.jennifer@gmail.com>

* fix: downgrade helm to v3.8.1 for compatability

The version of containerd used in helm 3.9.0 is not
compatibile with version 0.24.0 of k8s/component-base.
To allow the upgrade of other components, the render method has
been refactored to removed the uneccessary import of kube packages from helm.

Signed-off-by: Jennifer Power <barnabei.jennifer@gmail.com>

* fix: adds MaxICSPSize to operator mirror options in cli package

Signed-off-by: Jennifer Power <barnabei.jennifer@gmail.com>

* fix(helm): changes render method to use default chart capabilities

Signed-off-by: Jennifer Power <barnabei.jennifer@gmail.com>

* fix(mirror): adds logic for skip-missing for association errors

Fixes #476

Signed-off-by: Jennifer Power <barnabei.jennifer@gmail.com>

* docs: updates flag usage to reflect skip-missing fix and comments in helm.go

Signed-off-by: Jennifer Power <barnabei.jennifer@gmail.com>

* [CI] fix integration test race on log checks

Co-authored-by: James Harmison <jharmison@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug.
Projects
Development

Successfully merging a pull request may close this issue.

1 participant