-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MULTIARCH-3440: refine multiarch support for test-unit and test-e2e using dockerfile and add ppc64le build to Makefile #624
Conversation
@prb112: This pull request references MULTIARCH-3440 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
1 similar comment
@prb112: This pull request references MULTIARCH-3440 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/lgtm |
…sing dockerfile and add ppc64le build to Makefile - Update the .goreleaser.yaml to include ppc64le - Update the Dockerfile to include wget and pigz dependency - Update the Dockerfile to consider arch it's built on - Update the util.sh to be arch agnostic - Update the cross build for ppc64le Signed-off-by: Paul Bastide <pbastide@redhat.com>
Signed-off-by: Paul Bastide <pbastide@us.ibm.com> Co-authored-by: Jan Schintag <43986265+jschintag@users.noreply.github.com>
- Update the .goreleaser.yaml to include s390x - Update the cross build for s390x - Link gcc to s390x-linux-gnu-gcc binary On s390x go compiler seems to expect the gcc binary at s390x-linux-gnu-gcc binary. However on rhel it is not installed there. Signed-off-by: Jan Schintag <jan.schintag@de.ibm.com>
- Update the .goreleaser.yaml to include s390x - Update the cross build for s390x - Link gcc to s390x-linux-gnu-gcc binary On s390x go compiler seems to expect the gcc binary at s390x-linux-gnu-gcc binary. However on rhel it is not installed there. Signed-off-by: Jan Schintag <jan.schintag@de.ibm.com>
/retest |
@prb112 - could you have a look at the e2e test - its failing here use |
@lmzuccarelli yes - doing so... I moved some scripts around and left the e2e running last night. |
@prb112 - thanks again for the update. Let us know when we can review and finally merge |
Will do - I am testing on ppc now |
ed1bfbc
to
ae964e8
Compare
…rches and add arm64 Signed-off-by: Paul Bastide <pbastide@redhat.com>
Hey @lmzuccarelli - I've sent details on the changes in an email. It reflects our conversations and the testing is complete with s390x, ppc64le and amd64. thanks, Paul |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Thanks for this PR @prb112 @jschintag and @dorzel
I left a small comment on the Makefile, in case a cross build for arm is needed
/approve |
Signed-off-by: Paul Bastide <pbastide@redhat.com>
Hi @lmzuccarelli per a request from @dorzel and @sherine-k I've added a cross-build for arm64. Please review at your convenience / review for LGTM. Take care, Paul |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks so much!
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lmzuccarelli, prb112, sherine-k The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/payload-job periodic-ci-openshift-hypershift-release-4.14-periodics-e2e-aws-ovn |
@dgoodwin: trigger 0 job(s) for the /payload-(job|aggregate) command |
/label jira/valid-bug |
@prb112: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Description
This PR enables multiarch support in the build and tests in this case ppc64le.
Note, the PR #1680 builds go-containerregistry for ppc64le. When a new release is cut for the go-containerregistry, this build will not be necessary.
opm requires a Power9 machine to run.
Fixes # MULTIARCH-3440
Type of change
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Test Configuration:
Checklist: