-
Notifications
You must be signed in to change notification settings - Fork 377
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OCPBUGS-27489: Use correct hash sum of extracted tarball after re-signing with codesign #1659
Conversation
When binaries are extracted via `oc adm release extract` command, we have to re-sign these binaries if the operating system is `darwin` and architecture is `arm64`. This manual re-signing process seems to be working well, at least we haven't gotten any issues so far. However, since we make modifications to tarball during the re-signing process, this changes the hash sum value of the tarball, whereas the value in sha256sum file refers to the hash sum of the tarball prior to re-sign process creates disperancy. This PR writes modified tarball's hash sum value in sha256sum file to prevent mismatches.
@ardaguclu: This pull request references Jira Issue OCPBUGS-27489, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
/jira refresh |
@ardaguclu: This pull request references Jira Issue OCPBUGS-27489, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
/hold |
/retest |
/label qe-approved |
@ardaguclu: This pull request references Jira Issue OCPBUGS-27489, which is valid. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
/hold cancel |
/cc @ingvagabund |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ardaguclu, ingvagabund The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
not related; |
@ardaguclu: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
@ardaguclu: Jira Issue OCPBUGS-27489: All pull requests linked via external trackers have merged: Jira Issue OCPBUGS-27489 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
[ART PR BUILD NOTIFIER] This PR has been included in build openshift-enterprise-cli-container-v4.16.0-202401242108.p0.g34d0ed8.assembly.stream for distgit openshift-enterprise-cli. |
See: openshift/oc#1659 Signed-off-by: Victor Rubezhny <vrubezhny@redhat.com>
See: openshift/oc#1659 Signed-off-by: Victor Rubezhny <vrubezhny@redhat.com>
See: openshift/oc#1659 Signed-off-by: Victor Rubezhny <vrubezhny@redhat.com>
See: openshift/oc#1659 Signed-off-by: Victor Rubezhny <vrubezhny@redhat.com>
See: openshift/oc#1659 Signed-off-by: Victor Rubezhny <vrubezhny@redhat.com>
See: openshift/oc#1659 Signed-off-by: Victor Rubezhny <vrubezhny@redhat.com>
See: openshift/oc#1659 Signed-off-by: Victor Rubezhny <vrubezhny@redhat.com>
See: openshift/oc#1659 Signed-off-by: Victor Rubezhny <vrubezhny@redhat.com>
See: openshift/oc#1659 Signed-off-by: Victor Rubezhny <vrubezhny@redhat.com>
See: openshift/oc#1659 Signed-off-by: Victor Rubezhny <vrubezhny@redhat.com>
When binaries are extracted via
oc adm release extract
command, we have to re-sign these binaries if the operating system isdarwin
and architecture isarm64
. This manual re-signing process seems to be working well, at least we haven't gotten any issues so far. However, since we make modifications to tarball during the re-signing process, this changes the hash sum value of the tarball, whereas the value in sha256sum file refers to the hash sum of the tarball prior to re-sign process creates disperancy.This PR writes modified tarball's hash sum value in sha256sum file to prevent mismatches.
This PR can be considered as a continuation of #1242