Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCPBUGS-27489: Use correct hash sum of extracted tarball after re-signing with codesign #1659

Merged
merged 1 commit into from
Jan 24, 2024

Conversation

ardaguclu
Copy link
Member

When binaries are extracted via oc adm release extract command, we have to re-sign these binaries if the operating system is darwin and architecture is arm64. This manual re-signing process seems to be working well, at least we haven't gotten any issues so far. However, since we make modifications to tarball during the re-signing process, this changes the hash sum value of the tarball, whereas the value in sha256sum file refers to the hash sum of the tarball prior to re-sign process creates disperancy.

This PR writes modified tarball's hash sum value in sha256sum file to prevent mismatches.

This PR can be considered as a continuation of #1242

When binaries are extracted via `oc adm release extract` command,
we have to re-sign these binaries if the operating system is `darwin`
and architecture is `arm64`. This manual re-signing process seems to
be working well, at least we haven't gotten any issues so far.
However, since we make modifications to tarball during the re-signing process,
this changes the hash sum value of the tarball, whereas the value in sha256sum
file refers to the hash sum of the tarball prior to re-sign process creates
disperancy.

This PR writes modified tarball's hash sum value in sha256sum file
to prevent mismatches.
@openshift-ci-robot openshift-ci-robot added jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Jan 23, 2024
@openshift-ci-robot
Copy link

@ardaguclu: This pull request references Jira Issue OCPBUGS-27489, which is invalid:

  • expected the bug to target the "4.16.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

When binaries are extracted via oc adm release extract command, we have to re-sign these binaries if the operating system is darwin and architecture is arm64. This manual re-signing process seems to be working well, at least we haven't gotten any issues so far. However, since we make modifications to tarball during the re-signing process, this changes the hash sum value of the tarball, whereas the value in sha256sum file refers to the hash sum of the tarball prior to re-sign process creates disperancy.

This PR writes modified tarball's hash sum value in sha256sum file to prevent mismatches.

This PR can be considered as a continuation of #1242

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@ardaguclu
Copy link
Member Author

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Jan 23, 2024
@openshift-ci-robot
Copy link

@ardaguclu: This pull request references Jira Issue OCPBUGS-27489, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.16.0) matches configured target version for branch (4.16.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 23, 2024
@ardaguclu
Copy link
Member Author

/hold
I verified that this fix works properly but we still will need pre-merge testing.

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 23, 2024
@ardaguclu
Copy link
Member Author

/retest

@zhouying7780
Copy link
Contributor

/label qe-approved

@openshift-ci openshift-ci bot added the qe-approved Signifies that QE has signed off on this PR label Jan 24, 2024
@openshift-ci-robot
Copy link

@ardaguclu: This pull request references Jira Issue OCPBUGS-27489, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.16.0) matches configured target version for branch (4.16.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

In response to this:

When binaries are extracted via oc adm release extract command, we have to re-sign these binaries if the operating system is darwin and architecture is arm64. This manual re-signing process seems to be working well, at least we haven't gotten any issues so far. However, since we make modifications to tarball during the re-signing process, this changes the hash sum value of the tarball, whereas the value in sha256sum file refers to the hash sum of the tarball prior to re-sign process creates disperancy.

This PR writes modified tarball's hash sum value in sha256sum file to prevent mismatches.

This PR can be considered as a continuation of #1242

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@ardaguclu
Copy link
Member Author

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 24, 2024
@ardaguclu
Copy link
Member Author

/cc @ingvagabund
Could you please take a look at, when you are available?. Thanks.

@ingvagabund
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 24, 2024
Copy link
Contributor

openshift-ci bot commented Jan 24, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ardaguclu, ingvagabund

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ardaguclu
Copy link
Member Author

not related;
/retest-required

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 36702f9 and 2 for PR HEAD 93729f4 in total

Copy link
Contributor

openshift-ci bot commented Jan 24, 2024

@ardaguclu: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 34d0ed8 into openshift:master Jan 24, 2024
13 checks passed
@openshift-ci-robot
Copy link

@ardaguclu: Jira Issue OCPBUGS-27489: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-27489 has been moved to the MODIFIED state.

In response to this:

When binaries are extracted via oc adm release extract command, we have to re-sign these binaries if the operating system is darwin and architecture is arm64. This manual re-signing process seems to be working well, at least we haven't gotten any issues so far. However, since we make modifications to tarball during the re-signing process, this changes the hash sum value of the tarball, whereas the value in sha256sum file refers to the hash sum of the tarball prior to re-sign process creates disperancy.

This PR writes modified tarball's hash sum value in sha256sum file to prevent mismatches.

This PR can be considered as a continuation of #1242

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@ardaguclu ardaguclu deleted the ocpbugs-27489 branch January 24, 2024 19:59
@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

This PR has been included in build openshift-enterprise-cli-container-v4.16.0-202401242108.p0.g34d0ed8.assembly.stream for distgit openshift-enterprise-cli.
All builds following this will include this PR.

vrubezhny added a commit to redhat-developer/vscode-openshift-tools that referenced this pull request Jan 31, 2024
See: openshift/oc#1659

Signed-off-by: Victor Rubezhny <vrubezhny@redhat.com>
vrubezhny added a commit to redhat-developer/vscode-openshift-tools that referenced this pull request Jan 31, 2024
See: openshift/oc#1659

Signed-off-by: Victor Rubezhny <vrubezhny@redhat.com>
vrubezhny added a commit to redhat-developer/vscode-openshift-tools that referenced this pull request Feb 15, 2024
See: openshift/oc#1659

Signed-off-by: Victor Rubezhny <vrubezhny@redhat.com>
vrubezhny added a commit to redhat-developer/vscode-openshift-tools that referenced this pull request Feb 15, 2024
See: openshift/oc#1659

Signed-off-by: Victor Rubezhny <vrubezhny@redhat.com>
vrubezhny added a commit to redhat-developer/vscode-openshift-tools that referenced this pull request Feb 21, 2024
See: openshift/oc#1659

Signed-off-by: Victor Rubezhny <vrubezhny@redhat.com>
vrubezhny added a commit to redhat-developer/vscode-openshift-tools that referenced this pull request Feb 21, 2024
See: openshift/oc#1659

Signed-off-by: Victor Rubezhny <vrubezhny@redhat.com>
vrubezhny added a commit to redhat-developer/vscode-openshift-tools that referenced this pull request Feb 28, 2024
See: openshift/oc#1659

Signed-off-by: Victor Rubezhny <vrubezhny@redhat.com>
vrubezhny added a commit to redhat-developer/vscode-openshift-tools that referenced this pull request Feb 28, 2024
See: openshift/oc#1659

Signed-off-by: Victor Rubezhny <vrubezhny@redhat.com>
vrubezhny added a commit to redhat-developer/vscode-openshift-tools that referenced this pull request Feb 29, 2024
See: openshift/oc#1659

Signed-off-by: Victor Rubezhny <vrubezhny@redhat.com>
vrubezhny added a commit to redhat-developer/vscode-openshift-tools that referenced this pull request Feb 29, 2024
See: openshift/oc#1659

Signed-off-by: Victor Rubezhny <vrubezhny@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. qe-approved Signifies that QE has signed off on this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants