-
Notifications
You must be signed in to change notification settings - Fork 376
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug 1774642: pkg/cli/admin/release/extract: Multi-arch extraction with --filter-by-os #172
Conversation
@wking: This pull request references Bugzilla bug 1774642, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: wking The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
$ git describe
openshift-clients-4.3.0-201910250623-67-g9210429b0
$ go build -o ocx ./cmd/oc && ./ocx adm release extract --command=oc --command-os=mac registry.svc.ci.openshift.org/ocp/release:4.3.0-0.ci-2019-11-20-121416
error: image did not contain /usr/share/openshift/darwin_amd64/oc
$ oc adm release info --image-for=cli-artifacts registry.svc.ci.openshift.org/ocp/release:4.3.0-0.ci-2019-11-20-121416
registry.svc.ci.openshift.org/ocp/4.3-2019-11-20-121416@sha256:6497d5cb7102903baf98bbc0e07144f04827a21dcd800ff61360d25228a2d2ce
$ podman pull registry.svc.ci.openshift.org/ocp/4.3-2019-11-20-121416@sha256:6497d5cb7102903baf98bbc0e07144f04827a21dcd800ff61360d25228a2d2ce
$ podman save --format oci-dir --output cli-artifacts registry.svc.ci.openshift.org/ocp/4.3-2019-11-20-121416@sha256:6497d5cb7102903baf98bbc0e07144f04827a21dcd800ff61360d25228a2d2ce
$ jq -r '.layers[].digest' cli-artifacts/manifest.json
sha256:2cab4440f9070965c8454792eee4b122bce5939cc6d21e554469f01e71712a89
sha256:64f2bd9f473b0ae150f07dc65aafb90beeec7ebaa722625055cb8c1ddede0b09
sha256:bd48b9cc9f65a873bde992c97649ace2895af41307502429527f35f1bebda2c0
sha256:86e61694888a7971fcd711f84b1eff117844813adb4ed388d34bdb2d347fd33d
sha256:915b7fb689e0bc593393a11994653ab633fbb9e671276a9e75be478bea24857a
sha256:a18473fcedd3f809beb23c3f491bf4d26548637b1acd354e85023e9f7c6f9666
$ tar -tf cli-artifacts/a18473fcedd3f809beb23c3f491bf4d26548637b1acd354e85023e9f7c6f9666
usr/
usr/share/
usr/share/openshift/
usr/share/openshift/.wh..wh..opq
usr/share/openshift/darwin_amd64/
usr/share/openshift/darwin_amd64/oc
usr/share/openshift/linux_amd64/
usr/share/openshift/linux_amd64/oc
usr/share/openshift/linux_arm64/
usr/share/openshift/linux_arm64/oc
usr/share/openshift/linux_ppc64le/
usr/share/openshift/linux_ppc64le/oc
usr/share/openshift/linux_s390x/
usr/share/openshift/linux_s390x/oc
usr/share/openshift/mac/
usr/share/openshift/mac/oc
usr/share/openshift/windows/
usr/share/openshift/windows/oc.exe
usr/share/openshift/windows_amd64/
usr/share/openshift/windows_amd64/oc.exe Ah, maybe it's the leading slash... |
9210429
to
d74a65a
Compare
@wking: This pull request references Bugzilla bug 1774642, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
$ git describe
openshift-clients-4.3.0-201910250623-67-gd74a65aad
$ go build -o ocx ./cmd/oc && ./ocx adm release extract --command=oc --command-os='*' registry.svc.ci.openshift.org/ocp/release:4.3.0-0.ci-2019-11-20-121416
error: unable to iterate over layer sha256:13caf755813923e69e25ff1a28cc65766d6dcaa12676e5e274db9ec828e55d71 from registry.svc.ci.openshift.org/ocp/4.3-2019-11-20-121416@sha256:6497d5cb7102903baf98bbc0e07144f04827a21dcd800ff61360d25228a2d2ce: unable to find target with mapping name openshift-client-linux-4.3.0-0.ci-2019-11-20-121416.tar.gz Still trying to figure this one out... |
Also teach oc to extract from standard locations e949088 (Enable all Linux arches in cli-artifacts, 2019-11-07, openshift#153) to avoid choking on hardlinks [1]: $ oc adm release extract --tools registry.svc.ci.openshift.org/ocp/release:4.3.0-0.ci-2019-11-20-121416 error: image did not contain usr/share/openshift/mac/oc Teaching extractTarget about architectures avoids conflicts with multiple architectures trying to use the no-longer-specific-enough oc-linux in targetsByName [2]: $ ./oc adm release extract --command=oc --command-os='*' registry.svc.ci.openshift.org/ocp/release:4.3.0-0.ci-2019-11-20-121416 error: unable to iterate over layer sha256:13caf755813923e69e25ff1a28cc65766d6dcaa12676e5e274db9ec828e55d71 from registry.svc.ci.openshift.org/ocp/4.3-2019-11-20-121416@sha256:6497d5cb7102903baf98bbc0e07144f04827a21dcd800ff61360d25228a2d2ce: unable to find target with mapping name openshift-client-linux-4.3.0-0.ci-2019-11-20-121416.tar.gz Adding --command-arch on top of that allows us to set currentArch to avoid extracting 'oc' for multiple architectures all into the same file (making it unlikely that you get the architecture you want ;). [1]: https://bugzilla.redhat.com/show_bug.cgi?id=1774642 [2]: openshift#172 (comment)
d74a65a
to
5a3452f
Compare
Also teach oc to extract from standard locations e949088 (Enable all Linux arches in cli-artifacts, 2019-11-07, openshift#153) to avoid choking on hardlinks [1]: $ oc adm release extract --tools registry.svc.ci.openshift.org/ocp/release:4.3.0-0.ci-2019-11-20-121416 error: image did not contain usr/share/openshift/mac/oc Teaching extractTarget about architectures avoids conflicts with multiple architectures trying to use the no-longer-specific-enough oc-linux in targetsByName [2]: $ ./oc adm release extract --command=oc --command-os='*' registry.svc.ci.openshift.org/ocp/release:4.3.0-0.ci-2019-11-20-121416 error: unable to iterate over layer sha256:13caf755813923e69e25ff1a28cc65766d6dcaa12676e5e274db9ec828e55d71 from registry.svc.ci.openshift.org/ocp/4.3-2019-11-20-121416@sha256:6497d5cb7102903baf98bbc0e07144f04827a21dcd800ff61360d25228a2d2ce: unable to find target with mapping name openshift-client-linux-4.3.0-0.ci-2019-11-20-121416.tar.gz Adding --command-arch on top of that allows us to set currentArch to avoid extracting 'oc' for multiple architectures all into the same file (making it unlikely that you get the architecture you want ;). [1]: https://bugzilla.redhat.com/show_bug.cgi?id=1774642 [2]: openshift#172 (comment)
5a3452f
to
f46e4c4
Compare
$ git describe
openshift-clients-4.3.0-201910250623-67-gf46e4c422
$ go build -o ocx ./cmd/oc
$ ./ocx adm release extract --tools registry.svc.ci.openshift.org/ocp/release:4.3.0-0.ci-2019-11-20-121416
$ cat sha256sum.txt
3921c887913e19c0c0fe6336dc7e7fb234fb12fdf4e67114a8980ba010379326 openshift-client-linux-4.3.0-0.ci-2019-11-20-121416.tar.gz
5d9d614915852828d959341c4c765b38d38fd1998a8dfff11b384767316f2372 openshift-install-linux-4.3.0-0.ci-2019-11-20-121416.tar.gz
d115798f2647790b372efa9b33c26870aecc4bf2d311547233e1a099a8422e47 release.txt
$ ./ocx adm release extract --tools --command-arch=s390x registry.svc.ci.openshift.org/ocp/release:4.3.0-0.ci-2019-11-20-121416
$ cat sha256sum.txt
9918a2617b36fe6d09682c687f459bac3dc167a9a1c658baeb314d57b77943aa openshift-client-linux-s390x-4.3.0-0.ci-2019-11-20-121416.tar.gz
d115798f2647790b372efa9b33c26870aecc4bf2d311547233e1a099a8422e47 release.txt
$ ./ocx adm release extract --tools --command-arch='*' registry.svc.ci.openshift.org/ocp/release:4.3.0-0.ci-2019-11-20-121416
$ cat sha256sum.txt
3921c887913e19c0c0fe6336dc7e7fb234fb12fdf4e67114a8980ba010379326 openshift-client-linux-4.3.0-0.ci-2019-11-20-121416.tar.gz
124c365add2c0745e6d2cd6ea6b435db9d397e3b6d7e9f7aa8e7b9cd928b56a6 openshift-client-linux-arm64-4.3.0-0.ci-2019-11-20-121416.tar.gz
3b7641d90d814e54aa3617a5a3078ba63c004060b5a6a713f52f228c6c03cd32 openshift-client-linux-ppc64le-4.3.0-0.ci-2019-11-20-121416.tar.gz
9918a2617b36fe6d09682c687f459bac3dc167a9a1c658baeb314d57b77943aa openshift-client-linux-s390x-4.3.0-0.ci-2019-11-20-121416.tar.gz
5d9d614915852828d959341c4c765b38d38fd1998a8dfff11b384767316f2372 openshift-install-linux-4.3.0-0.ci-2019-11-20-121416.tar.gz
d115798f2647790b372efa9b33c26870aecc4bf2d311547233e1a099a8422e47 release.txt
$ ./ocx adm release extract --tools --command-os=windows --command-arch=amd64 registry.svc.ci.openshift.org/ocp/release:4.3.0-0.ci-2019-11-20-121416error: image did not contain usr/share/openshift/windows_amd64/oc.exe
error: image did not contain usr/share/openshift/windows_amd64/oc.exe So close :p |
$ tar -tvf cli-artifacts/a18473fcedd3f809beb23c3f491bf4d26548637b1acd354e85023e9f7c6f9666
drwxr-xr-x 0/0 0 2019-10-08 05:41 usr/
drwxr-xr-x 0/0 0 2019-11-18 20:35 usr/share/
drwxr-xr-x 0/0 0 2019-11-18 20:35 usr/share/openshift/
-rwxr-xr-x 0/0 0 1969-12-31 16:00 usr/share/openshift/.wh..wh..opq
drwxr-xr-x 0/0 0 2019-11-18 20:31 usr/share/openshift/darwin_amd64/
-rwxr-xr-x 0/0 93382160 2019-11-18 20:31 usr/share/openshift/darwin_amd64/oc
drwxr-xr-x 0/0 0 2019-11-18 20:33 usr/share/openshift/linux_amd64/
-rwxr-xr-x 0/0 82720408 2019-11-18 20:33 usr/share/openshift/linux_amd64/oc
drwxr-xr-x 0/0 0 2019-11-18 20:34 usr/share/openshift/linux_arm64/
-rwxr-xr-x 0/0 77812608 2019-11-18 20:34 usr/share/openshift/linux_arm64/oc
drwxr-xr-x 0/0 0 2019-11-18 20:35 usr/share/openshift/linux_ppc64le/
-rwxr-xr-x 0/0 79059232 2019-11-18 20:35 usr/share/openshift/linux_ppc64le/oc
drwxr-xr-x 0/0 0 2019-11-18 20:35 usr/share/openshift/linux_s390x/
-rwxr-xr-x 0/0 81223040 2019-11-18 20:35 usr/share/openshift/linux_s390x/oc
drwxr-xr-x 0/0 0 2019-11-18 20:35 usr/share/openshift/mac/
hrwxr-xr-x 0/0 0 2019-11-18 20:31 usr/share/openshift/mac/oc link to usr/share/openshift/darwin_amd64/oc
drwxr-xr-x 0/0 0 2019-11-18 20:35 usr/share/openshift/windows/
-rwxr-xr-x 0/0 81619968 2019-11-18 20:32 usr/share/openshift/windows/oc.exe
drwxr-xr-x 0/0 0 2019-11-18 20:32 usr/share/openshift/windows_amd64/
hrwxr-xr-x 0/0 0 2019-11-18 20:32 usr/share/openshift/windows_amd64/oc.exe link to usr/share/openshift/windows/oc.exe |
Also teach oc to extract from standard locations e949088 (Enable all Linux arches in cli-artifacts, 2019-11-07, openshift#153) to avoid choking on hardlinks [1]: $ oc adm release extract --tools registry.svc.ci.openshift.org/ocp/release:4.3.0-0.ci-2019-11-20-121416 error: image did not contain usr/share/openshift/mac/oc Teaching extractTarget about architectures avoids conflicts with multiple architectures trying to use the no-longer-specific-enough oc-linux in targetsByName [2]: $ ./oc adm release extract --command=oc --command-os='*' registry.svc.ci.openshift.org/ocp/release:4.3.0-0.ci-2019-11-20-121416 error: unable to iterate over layer sha256:13caf755813923e69e25ff1a28cc65766d6dcaa12676e5e274db9ec828e55d71 from registry.svc.ci.openshift.org/ocp/4.3-2019-11-20-121416@sha256:6497d5cb7102903baf98bbc0e07144f04827a21dcd800ff61360d25228a2d2ce: unable to find target with mapping name openshift-client-linux-4.3.0-0.ci-2019-11-20-121416.tar.gz Adding --command-arch on top of that allows us to set currentArch to avoid extracting 'oc' for multiple architectures all into the same file (making it unlikely that you get the architecture you want ;). Updated the completions with: $ make build $ hack/update-generated-completions.sh [1]: https://bugzilla.redhat.com/show_bug.cgi?id=1774642 [2]: openshift#172 (comment)
f46e4c4
to
c60223d
Compare
$ git describe
openshift-clients-4.3.0-201910250623-67-gc60223d63
$ go build -o ocx ./cmd/oc
$ ./ocx adm release extract --tools --command-os=windows --command-arch=amd64 registry.svc.ci.openshift.org/ocp/release:4.3.0-0.ci-2019-11-20-121416
$ cat sha256sum.txt
7e6b446bc63a640b53a95e0a6f0b5843f88f0f1fff5ff7446e94401208a3d681 openshift-client-windows-4.3.0-0.ci-2019-11-20-121416.tar.gz
d115798f2647790b372efa9b33c26870aecc4bf2d311547233e1a099a8422e47 release.txt
$ go build -o ocx ./cmd/oc && ./ocx adm release extract --tools --command-os='*' --command-arch='*' registry.svc.ci.openshift.org/ocp/release:4.3.0-0.ci-2019-11-20-121416
$ cat sha256sum.txt
3921c887913e19c0c0fe6336dc7e7fb234fb12fdf4e67114a8980ba010379326 openshift-client-linux-4.3.0-0.ci-2019-11-20-121416.tar.gz
124c365add2c0745e6d2cd6ea6b435db9d397e3b6d7e9f7aa8e7b9cd928b56a6 openshift-client-linux-arm64-4.3.0-0.ci-2019-11-20-121416.tar.gz
3b7641d90d814e54aa3617a5a3078ba63c004060b5a6a713f52f228c6c03cd32 openshift-client-linux-ppc64le-4.3.0-0.ci-2019-11-20-121416.tar.gz
9918a2617b36fe6d09682c687f459bac3dc167a9a1c658baeb314d57b77943aa openshift-client-linux-s390x-4.3.0-0.ci-2019-11-20-121416.tar.gz
0124abefcc68492d6cd61730d49c834c3eca2be8a1dee22520e74c8fc4ea4958 openshift-client-mac-4.3.0-0.ci-2019-11-20-121416.tar.gz
7e6b446bc63a640b53a95e0a6f0b5843f88f0f1fff5ff7446e94401208a3d681 openshift-client-windows-4.3.0-0.ci-2019-11-20-121416.tar.gz
5d9d614915852828d959341c4c765b38d38fd1998a8dfff11b384767316f2372 openshift-install-linux-4.3.0-0.ci-2019-11-20-121416.tar.gz
57d9c5efaefa5730a2ab4dd2dc2d3615e1093b8332a34d7c816c9db008740f21 openshift-install-mac-4.3.0-0.ci-2019-11-20-121416.tar.gz
d115798f2647790b372efa9b33c26870aecc4bf2d311547233e1a099a8422e47 release.txt So c60223d looks good to me. |
Also teach oc to extract from standard locations e949088 (Enable all Linux arches in cli-artifacts, 2019-11-07, openshift#153) to avoid choking on hardlinks [1]: $ oc adm release extract --tools registry.svc.ci.openshift.org/ocp/release:4.3.0-0.ci-2019-11-20-121416 error: image did not contain usr/share/openshift/mac/oc Teaching extractTarget about architectures avoids conflicts with multiple architectures trying to use the no-longer-specific-enough oc-linux in targetsByName [2]: $ ./oc adm release extract --command=oc --command-os='*' registry.svc.ci.openshift.org/ocp/release:4.3.0-0.ci-2019-11-20-121416 error: unable to iterate over layer sha256:13caf755813923e69e25ff1a28cc65766d6dcaa12676e5e274db9ec828e55d71 from registry.svc.ci.openshift.org/ocp/4.3-2019-11-20-121416@sha256:6497d5cb7102903baf98bbc0e07144f04827a21dcd800ff61360d25228a2d2ce: unable to find target with mapping name openshift-client-linux-4.3.0-0.ci-2019-11-20-121416.tar.gz Adding --command-arch on top of that allows us to set currentArch to avoid extracting 'oc' for multiple architectures all into the same file (making it unlikely that you get the architecture you want ;). Updated the completions with: $ make build $ hack/update-generated-completions.sh [1]: https://bugzilla.redhat.com/show_bug.cgi?id=1774642 [2]: openshift#172 (comment)
c60223d
to
4820f6c
Compare
Hrm, I should probably reroll to deprecate /hold |
Deprecating the previous --command-os to get consistency with other image handling. --filter-by-os originally landed in openshift/origin@e04b16527b (cli: Mirror images across registries or to S3, 2017-06-04, openshift/origin#14471). The wrapping in: o.FilterOptions.FilterByOS = fmt.Sprintf("^%s/", o.CommandOperatingSystem) guards against the unlikely case that a given --command-os value is a valid prefix for a longer OS, or matches an arch or varient or some such. Also teach oc to extract from standard locations e949088 (Enable all Linux arches in cli-artifacts, 2019-11-07, openshift#153) to avoid choking on hardlinks [1]: $ oc adm release extract --tools registry.svc.ci.openshift.org/ocp/release:4.3.0-0.ci-2019-11-20-121416 error: image did not contain usr/share/openshift/mac/oc Teaching extractTarget about architectures avoids conflicts with multiple architectures trying to use the no-longer-specific-enough oc-linux in targetsByName [2]: $ ./oc adm release extract --command=oc --command-os='*' registry.svc.ci.openshift.org/ocp/release:4.3.0-0.ci-2019-11-20-121416 error: unable to iterate over layer sha256:13caf755813923e69e25ff1a28cc65766d6dcaa12676e5e274db9ec828e55d71 from registry.svc.ci.openshift.org/ocp/4.3-2019-11-20-121416@sha256:6497d5cb7102903baf98bbc0e07144f04827a21dcd800ff61360d25228a2d2ce: unable to find target with mapping name openshift-client-linux-4.3.0-0.ci-2019-11-20-121416.tar.gz Adding --command-arch on top of that allows us to set currentArch to avoid extracting 'oc' for multiple architectures all into the same file (making it unlikely that you get the architecture you want ;). Updated the completions with: $ make build $ hack/update-generated-completions.sh [1]: https://bugzilla.redhat.com/show_bug.cgi?id=1774642 [2]: openshift#172 (comment)
4820f6c
to
88d9a93
Compare
Deprecating the previous --command-os to get consistency with other image handling. --filter-by-os originally landed in openshift/origin@e04b16527b (cli: Mirror images across registries or to S3, 2017-06-04, openshift/origin#14471). The wrapping in: o.FilterOptions.FilterByOS = fmt.Sprintf("^%s/", o.CommandOperatingSystem) guards against the unlikely case that a given --command-os value is a valid prefix for a longer OS, or matches an arch or varient or some such. Also teach oc to extract from standard locations e949088 (Enable all Linux arches in cli-artifacts, 2019-11-07, openshift#153) to avoid choking on hardlinks [1]: $ oc adm release extract --tools registry.svc.ci.openshift.org/ocp/release:4.3.0-0.ci-2019-11-20-121416 error: image did not contain usr/share/openshift/mac/oc Teaching extractTarget about architectures avoids conflicts with multiple architectures trying to use the no-longer-specific-enough oc-linux in targetsByName [2]: $ ./oc adm release extract --command=oc --command-os='*' registry.svc.ci.openshift.org/ocp/release:4.3.0-0.ci-2019-11-20-121416 error: unable to iterate over layer sha256:13caf755813923e69e25ff1a28cc65766d6dcaa12676e5e274db9ec828e55d71 from registry.svc.ci.openshift.org/ocp/4.3-2019-11-20-121416@sha256:6497d5cb7102903baf98bbc0e07144f04827a21dcd800ff61360d25228a2d2ce: unable to find target with mapping name openshift-client-linux-4.3.0-0.ci-2019-11-20-121416.tar.gz Adding --command-arch on top of that allows us to set currentArch to avoid extracting 'oc' for multiple architectures all into the same file (making it unlikely that you get the architecture you want ;). Updated the completions with: $ make build $ hack/update-generated-completions.sh [1]: https://bugzilla.redhat.com/show_bug.cgi?id=1774642 [2]: openshift#172 (comment)
88d9a93
to
85df592
Compare
These are where the binaries lived before e949088 (Enable all Linux arches in cli-artifacts, 2019-11-07, openshift#153), and since the extraction chokes on hardlinks [1], we need to be looking at those locations to extract from 4.2.z and older releases. Also shuffles the Dockerfile around to move the darwin and Windows builds to their old locations and symlink them from the standard locations. That way older 4.2.z releases will find regular files at the locations they expect, but that we'll be able to serve files from the standardized pattern in the downloads deployment [2]. I'm also removing the cli-artifacts-built linux/amd64 binary in favor of the build we inherited from the parent cli image. [1]: https://bugzilla.redhat.com/show_bug.cgi?id=1774642 [2]: openshift/console-operator#354
$ git describe
openshift-clients-4.3.0-201910250623-68-ge23baae6a
$ go build -o ocx ./cmd/oc
$ ./ocx adm release extract --tools --filter-by-os='.*' quay.io/openshift-release-dev/ocp-release:4.2.4
error: unable to find multiple files: usr/share/openshift/linux_arm64/oc, usr/share/openshift/linux_ppc64le/oc, usr/share/openshift/linux_s390x/oc Grr, I need to reroll the /hold |
With this command, we still error out if we didn't extract anything. But if we got through the tarball without erroring on an extraction and we got something out, just accept that missing files are because the image being used didn't have some possible target, and that that's ok. Avoids: $ oc adm release extract --tools --filter-by-os='.*' quay.io/openshift-release-dev/ocp-release:4.2.4 error: unable to find multiple files: usr/share/openshift/linux_arm64/oc, usr/share/openshift/linux_ppc64le/oc, usr/share/openshift/linux_s390x/oc when we expect 4.2.4's cli-artifacts to be missing those new non-amd64 binaries.
/retest |
/hold cancel |
@wking: PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@wking: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Issues go stale after 90d of inactivity. Mark the issue as fresh by commenting If this issue is safe to close now please do so with /lifecycle stale |
@wking: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Stale issues rot after 30d of inactivity. Mark the issue as fresh by commenting If this issue is safe to close now please do so with /lifecycle rotten |
Rotten issues close after 30d of inactivity. Reopen the issue by commenting /close |
@openshift-bot: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@wking: This pull request references Bugzilla bug 1774642. The bug has been updated to no longer refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Avoid:
by avoiding the hardlink paths and teaching extract about the new canonical paths from e949088 (#153).