Add free and paid online-extensions.js files for custom quota messages #40
Conversation
openshift-ci-robot
added
do-not-merge/work-in-progress
damemi
requested review from
abhgupta and
dak1n1
and removed request for
dinhxuanvu and
sallyom
|
I always like to run wording by @wgordon17 . The current wording is: Thanks for CCing me on this change. It can probably go out with next week's update. |
There was a problem hiding this comment.
Wow, it's a lot harder to remove the "you" from the Pro plan messaging than I would've thought. I put one suggestion in there without "you", but it sounds kinda weird. I'll let @damemi pick which he likes.
I would also like to see persistentvolumeclaims and requests.storage added as notification messages.
|
|
||
| window.OPENSHIFT_CONSTANTS.QUOTA_NOTIFICATION_MESSAGE = { | ||
| "limits.memory": "Upgrade to <a href=\""+window.OPENSHIFT_EXTENSION_PROPERTIES.account_url+"/register/plan\">OpenShift Online Pro</a> if you need more resources", | ||
| "limits.cpu": "Upgrade to <a href=\""+window.OPENSHIFT_EXTENSION_PROPERTIES.account_url+"/register/plan\">OpenShift Online Pro</a> if you need more resources" |
There was a problem hiding this comment.
Some suggested edits:
Get access to additional resources by upgrading to OpenShift Online Pro.
Access additional resources by upgrade to OpenShift Online Pro.
Upgrade to OpenShift Online Pro for access to additional resources.
OpenShift Online Pro provides additional resources.
|
|
||
| window.OPENSHIFT_CONSTANTS.QUOTA_NOTIFICATION_MESSAGE = { | ||
| "limits.memory": "You can <a href=\""+window.OPENSHIFT_EXTENSION_PROPERTIES.account_url+"\">upgrade your plan</a> if you need more resources", | ||
| "limits.cpu": "You can <a href=\""+window.OPENSHIFT_EXTENSION_PROPERTIES.account_url+"\">upgrade your plan</a> if you need more resources" |
There was a problem hiding this comment.
Some suggested edits:
<a>Add additional resources</a> to increase the quota.<a>Manage your subscription</a> to add additional resources.<a>Manage your subscription</a> to increase the quota.
damemi
force-pushed
the
quota-notification-message
branch
from
0c39bdb
to
0b1fa88
Compare
damemi
force-pushed
the
quota-notification-message
branch
from
0b1fa88
to
8c1628a
Compare
damemi
changed the title
openshift-ci-robot
removed
the
do-not-merge/work-in-progress
|
@sspeiche does this wording/approach look good to you? |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: abhgupta, damemi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Card: https://trello.com/c/BkleYWax/958-2-pro-provide-custom-messages-for-hitting-quotas
Note that adding these two files will require them to be added to the webconsole configmap under
scriptURLsin order to take effect, and only on their specific clustersScreenshot of paid cluster:
See this pr for reference: openshift/origin-web-console#2116
(Available quota messages: https://github.com/openshift/origin-web-console/blob/master/app/scripts/services/quota.js#L115)