Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCPBUGS-35209: Update Dockerfile to centos9 stream. #12503

Merged
merged 3 commits into from
Aug 9, 2024

Conversation

barbacbd
Copy link
Contributor

** Centos8 is End of Life as of May 31, 2024

** Centos8 is End of Life as of May 31, 2024
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jun 10, 2024
@openshift-ci-robot
Copy link

@barbacbd: This pull request references Jira Issue OCPBUGS-35209, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.17.0) matches configured target version for branch (4.17.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @gpei

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

** Centos8 is End of Life as of May 31, 2024

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. label Jun 10, 2024
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 10, 2024
@barbacbd
Copy link
Contributor Author

this will depend on openshift/release#53005

@barbacbd
Copy link
Contributor Author

barbacbd commented Jul 1, 2024

/retest-required

@patrickdillon
Copy link
Contributor

still not finding the python interpreter?
Saw

/bin/sh: /usr/bin/python3: No such file or directory

in the ansible logs

@barbacbd
Copy link
Contributor Author

barbacbd commented Jul 3, 2024

/test unit

@barbacbd
Copy link
Contributor Author

barbacbd commented Jul 3, 2024

/test e2e-aws-workers-rhel8

@gpei
Copy link
Contributor

gpei commented Jul 4, 2024

@patrickdillon @barbacbd

still not finding the python interpreter?
Saw

/bin/sh: /usr/bin/python3: No such file or directory
in the ansible logs

I guess it's the same issue we're also seeing in QE's RHEL jobs since Jul 02, we think it's caused by the ansible-core update, now it's coming to version 2.17 on the ansible image, but it won't work against the RHEL-8 workers which has python-3.6 installed on the system by default, please see https://www.jeffgeerling.com/blog/2024/newer-versions-ansible-dont-work-rhel-8

I also drafted a PR for fixing this today #12504, but just realized @barbacbd is also updating this file here, so I closed that one, maybe Brent could help to add the version locking in this PR and backport it to previous OCP versions together, thanks.

@gpei
Copy link
Contributor

gpei commented Jul 4, 2024

We also made a test with the ansible-core 2.17 and newer python versions on RHEL workers, which also could work. But considering python3.6 is the default one on RHEL-8 machines, so I guess it's better to limit the ansible-core version < 2.17 in our test.

  1. Install python3.9 on RHEL workers
  2. Set ansible_python_interpreter=/bin/python3.9 in the inventory.

@barbacbd
Copy link
Contributor Author

barbacbd commented Jul 9, 2024

/test images

@barbacbd
Copy link
Contributor Author

barbacbd commented Jul 9, 2024

/test e2e-aws-workers-rhel8

@barbacbd
Copy link
Contributor Author

/test e2e-aws-workers-rhel8

2 similar comments
@barbacbd
Copy link
Contributor Author

/test e2e-aws-workers-rhel8

@barbacbd
Copy link
Contributor Author

/test e2e-aws-workers-rhel8

@sdodson
Copy link
Member

sdodson commented Jul 30, 2024

/approve
Least bad immediately available option for CI. Will have to rely on QE to some extent to continue testing rhel8 ansible environment.

@sdodson
Copy link
Member

sdodson commented Jul 30, 2024

openshift/egress-router-cni#88 to fix egress-router-cni build issues for rhel8

@sdodson
Copy link
Member

sdodson commented Aug 4, 2024

/retest-required

@sdodson
Copy link
Member

sdodson commented Aug 5, 2024

Flake?
/test e2e-aws-workers-rhel8

Copy link
Contributor

openshift-ci bot commented Aug 5, 2024

@barbacbd: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@jhixson74
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 9, 2024
Copy link
Contributor

openshift-ci bot commented Aug 9, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: barbacbd, jhixson74, sdodson

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 444a9de into openshift:master Aug 9, 2024
5 checks passed
@openshift-ci-robot
Copy link

@barbacbd: Jira Issue OCPBUGS-35209: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-35209 has been moved to the MODIFIED state.

In response to this:

** Centos8 is End of Life as of May 31, 2024

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@gpei
Copy link
Contributor

gpei commented Aug 14, 2024

@barbacbd looks like we still need to backport this till 4.14 to align with openshift/release#53005

@gpei
Copy link
Contributor

gpei commented Aug 19, 2024

/jira backport release-4.16,release-4.15,release-4.14

@openshift-ci-robot
Copy link

@gpei: Missing required branches for backport chain:

  • openshift-4.17 OR release-4.17,

In response to this:

/jira backport release-4.16,release-4.15,release-4.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@gpei
Copy link
Contributor

gpei commented Aug 19, 2024

/cherry-pick release-4.16

@openshift-cherrypick-robot

@gpei: new pull request created: #12507

In response to this:

/cherry-pick release-4.16

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants