Creating initial tsb role to consume and apply templates provided for… #5226

ewolinetz · 2017-08-25T19:26:18Z

… tsb

Addresses:
https://bugzilla.redhat.com/show_bug.cgi?id=1486623
https://bugzilla.redhat.com/show_bug.cgi?id=1470623
https://bugzilla.redhat.com/show_bug.cgi?id=1491626

ewolinetz · 2017-08-28T21:15:42Z

Changes dependent on openshift/origin#15993

ewolinetz · 2017-09-08T17:06:53Z

@deads2k is this the correct way to handle the TSB config? I'm seeing this when I try to kubectl apply it

fatal: [m01.example.com]: FAILED! => {
    "changed": true, 
    "cmd": [
        "kubectl", 
        "apply", 
        "-f", 
        "/tmp/tsb-ansible-lS4vzn/apiserver-config.yaml"
    ], 
    "delta": "0:00:00.219908", 
    "end": "2017-09-08 16:51:36.256954", 
    "failed": true, 
    "invocation": {
        "module_args": {
            "_raw_params": "kubectl apply -f /tmp/tsb-ansible-lS4vzn/apiserver-config.yaml", 
            "_uses_shell": false, 
            "chdir": null, 
            "creates": null, 
            "executable": null, 
            "removes": null, 
            "warn": true
        }
    }, 
    "rc": 1, 
    "start": "2017-09-08 16:51:36.037046", 
    "stderr": "error: unable to recognize \"/tmp/tsb-ansible-lS4vzn/apiserver-config.yaml\": no matches for config.templateservicebroker.openshift.io/, Kind=TemplateServiceBrokerConfig", 
    "stderr_lines": [
        "error: unable to recognize \"/tmp/tsb-ansible-lS4vzn/apiserver-config.yaml\": no matches for config.templateservicebroker.openshift.io/, Kind=TemplateServiceBrokerConfig"
    ], 
    "stdout": "", 
    "stdout_lines": []
}

deads2k · 2017-09-08T17:39:49Z

I'm afraid I don't speak ansible very well. You're doing oc process -f install/templateservicebroker/apiserver-template.yaml | oc apply -f - or equivalent?

ewolinetz · 2017-09-08T18:11:30Z

@deads2k apologies... I'm doing kubectl apply -f /tmp/tsb-ansible-lS4vzn/apiserver-config.yaml should I do oc process -f .... | oc apply -f - ? My server returned saying that it doesn't recognize the object kind...

no matches for config.templateservicebroker.openshift.io/, Kind=TemplateServiceBrokerConfig

deads2k · 2017-09-08T18:14:17Z

I'm doing kubectl apply -f /tmp/tsb-ansible-lS4vzn/apiserver-config.yaml

I don't recognize that file. Is it a template file or a processed template (list)? If it is https://github.com/openshift/origin/blob/master/install/templateservicebroker/apiserver-config.yaml , then that's the config file for the server which you will pass to the template as a parameter. You don't apply that one.

ewolinetz · 2017-09-08T18:17:06Z

@deads2k ack, yes... I'm forgetting that there's that layer of abstraction. It is that config file... so when I create the server template I pass this as a parameter, got it! Much appreciated

ewolinetz · 2017-09-08T22:21:37Z

@sdodson @deads2k any qualms with separating this work from the work required for #5056 ?

sdodson · 2017-09-09T01:16:09Z

@sdodson @deads2k any qualms with separating this work from the work required for #5056 ?

No that's fine with me. #5056 would be addressed first?

ewolinetz · 2017-09-11T17:17:56Z

They'd both need to be delivered for 3.7 but it might make sense to get #5056 merged in first

kwoodson · 2017-09-12T14:13:06Z

roles/template_service_broker/tasks/remove.yml

@@ -0,0 +1,25 @@
+---


What do we do when any of these commands fail? How do we ensure that these objects are removed? Just something to think about.

ewolinetz · 2017-09-13T16:53:02Z

aos-ci-test

openshift-bot · 2017-09-13T22:48:21Z

success: "aos-ci-jenkins/OS_3.6_NOT_containerized, aos-ci-jenkins/OS_3.6_NOT_containerized_e2e_tests" for 36829d0 (logs)

openshift-bot · 2017-09-13T22:49:59Z

success: "aos-ci-jenkins/OS_3.6_containerized, aos-ci-jenkins/OS_3.6_containerized_e2e_tests" for 36829d0 (logs)

ewolinetz · 2017-09-18T19:00:39Z

/retest

ewolinetz · 2017-09-19T19:02:13Z

@deads2k with the latest tested locally I see the TSB pods start up and run after an installation

deads2k · 2017-09-19T19:50:14Z

@sdodson @kwoodson I haven't seen much review action on this. I don't know enough to meaningfully review it, but if it can get reviewed in time to prove the pattern you may be able to use it for something like service catalog this release too.

sdodson · 2017-09-19T21:10:22Z

roles/openshift_sanitize_inventory/tasks/__deprecations_metrics.yml

+
+- set_fact:
+    openshift_metrics_storage_kind: "{{ openshift_hosted_metrics_storage_kind }}"
+  when: openshift_hosted_metrics_storage_kind is defined


This file seems unrelated to the topic of the PR?

Ugh, i committed while on the wrong branch locally... but i thought i reverted it. Will remove

sdodson · 2017-09-19T21:12:22Z

roles/template_service_broker/tasks/install.yml

+  with_items:
+    - "{{ __tsb_template_file }}"
+    - "{{ __tsb_config_file }}"
+    - "{{ __tsb_rbac_file }}"


Has this stabilized enough that we should go ahead and add this content to openshift-ansible in the location we agreed upon rather than fetching it from origin github?

I thought the alternative to pulling the content from origin was going to be a locally sync'd place in ansible. Is that configured yet? We should be able to just change the source location in vars/

Yeah, we'll setup CI tooling for that but lets go ahead and import a copy of current content as part of this PR and use that rather than fetching from github?

sdodson · 2017-09-19T21:14:02Z

roles/template_service_broker/tasks/remove.yml

+
+- name: Delete template file
+  command: >
+    kubectl delete -f {{ mktemp.stdout }}/{{ __tsb_template_file }}


kubectl versus oc in the next task, is that intentional?

@deads2k delete on a template will delete all the resources defined in the template?

@deads2k delete on a template will delete all the resources defined in the template?

You need to process the template, then pipe that to delete. You probably want to delete the entire namespace (after doing this) just in case.

I was going to suggest just nuking the namespace.

I was going to suggest just nuking the namespace.

both are useful. Some resources which are created are cluster scoped. ClusterRoles for instance.

sdodson · 2017-09-19T21:15:34Z

Assuming the metrics related stuff is unrelated to this PR lets remove that then I'm LGTM.

ewolinetz · 2017-09-20T16:03:26Z

/retest

… tsb

ewolinetz · 2017-09-20T21:51:22Z

@sdodson @deads2k how does everything look?

sdodson

LGTM

sdodson · 2017-09-21T13:29:23Z

/lgtm

openshift-merge-robot · 2017-09-21T23:50:38Z

/test all [submit-queue is verifying that this PR is safe to merge]

sdodson · 2017-09-22T01:42:27Z

/retest

openshift-merge-robot · 2017-09-22T03:21:52Z

Automatic merge from submit-queue

ewolinetz force-pushed the template_service_broker branch from 3c8f020 to 2554302 Compare August 29, 2017 17:42

ewolinetz changed the title ~~[WIP] Creating initial tsb role to consume and apply tepmlates provided for…~~ [WIP] Creating initial tsb role to consume and apply templates provided for… Aug 31, 2017

ewolinetz force-pushed the template_service_broker branch from bec03f6 to 85520e0 Compare September 8, 2017 14:21

openshift-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Sep 8, 2017

ewolinetz force-pushed the template_service_broker branch from aa43fa3 to 36829d0 Compare September 8, 2017 21:59

ewolinetz changed the title ~~[WIP] Creating initial tsb role to consume and apply templates provided for…~~ Creating initial tsb role to consume and apply templates provided for… Sep 8, 2017

ewolinetz mentioned this pull request Sep 12, 2017

Service catalog roles must not use policy objects #4956

Closed

kwoodson reviewed Sep 12, 2017

View reviewed changes

ewolinetz mentioned this pull request Sep 13, 2017

Installer should not set pod_presets: true for web console extension in 3.7 #5403

Closed

sdodson reviewed Sep 19, 2017

View reviewed changes

ewolinetz mentioned this pull request Sep 20, 2017

Installer should not set service_catalog_landing_page: true for web console extension in 3.7 #5447

Closed

openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 20, 2017

ewolinetz force-pushed the template_service_broker branch from 841a4c6 to 7277cbc Compare September 20, 2017 15:51

openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 20, 2017

ewolinetz force-pushed the template_service_broker branch from 7277cbc to 5e4255c Compare September 20, 2017 18:20

Creating initial tsb role to consume and apply templates provided for…

dace516

… tsb

ewolinetz force-pushed the template_service_broker branch from 5e4255c to dace516 Compare September 20, 2017 18:32

sdodson approved these changes Sep 20, 2017

View reviewed changes

openshift-ci-robot assigned sdodson Sep 21, 2017

openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 21, 2017

openshift-merge-robot merged commit 2adb0eb into openshift:master Sep 22, 2017

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Creating initial tsb role to consume and apply templates provided for… #5226

Creating initial tsb role to consume and apply templates provided for… #5226

ewolinetz commented Aug 25, 2017 •

edited

Loading

ewolinetz commented Aug 28, 2017

ewolinetz commented Sep 8, 2017

deads2k commented Sep 8, 2017

ewolinetz commented Sep 8, 2017

deads2k commented Sep 8, 2017

ewolinetz commented Sep 8, 2017

ewolinetz commented Sep 8, 2017

sdodson commented Sep 9, 2017

ewolinetz commented Sep 11, 2017

kwoodson Sep 12, 2017

ewolinetz commented Sep 13, 2017

openshift-bot commented Sep 13, 2017

openshift-bot commented Sep 13, 2017

ewolinetz commented Sep 18, 2017

ewolinetz commented Sep 19, 2017

deads2k commented Sep 19, 2017

sdodson Sep 19, 2017

ewolinetz Sep 20, 2017

sdodson Sep 19, 2017

ewolinetz Sep 20, 2017

sdodson Sep 20, 2017 •

edited

Loading

sdodson Sep 19, 2017

sdodson Sep 19, 2017

deads2k Sep 20, 2017

sdodson Sep 20, 2017

deads2k Sep 20, 2017

sdodson commented Sep 19, 2017

ewolinetz commented Sep 20, 2017

ewolinetz commented Sep 20, 2017

sdodson left a comment

sdodson commented Sep 21, 2017

openshift-merge-robot commented Sep 21, 2017

sdodson commented Sep 22, 2017

openshift-merge-robot commented Sep 22, 2017

Creating initial tsb role to consume and apply templates provided for… #5226

Creating initial tsb role to consume and apply templates provided for… #5226

Conversation

ewolinetz commented Aug 25, 2017 • edited Loading

ewolinetz commented Aug 28, 2017

ewolinetz commented Sep 8, 2017

deads2k commented Sep 8, 2017

ewolinetz commented Sep 8, 2017

deads2k commented Sep 8, 2017

ewolinetz commented Sep 8, 2017

ewolinetz commented Sep 8, 2017

sdodson commented Sep 9, 2017

ewolinetz commented Sep 11, 2017

Choose a reason for hiding this comment

ewolinetz commented Sep 13, 2017

openshift-bot commented Sep 13, 2017

openshift-bot commented Sep 13, 2017

ewolinetz commented Sep 18, 2017

ewolinetz commented Sep 19, 2017

deads2k commented Sep 19, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

sdodson Sep 20, 2017 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

sdodson commented Sep 19, 2017

ewolinetz commented Sep 20, 2017

ewolinetz commented Sep 20, 2017

sdodson left a comment

Choose a reason for hiding this comment

sdodson commented Sep 21, 2017

openshift-merge-robot commented Sep 21, 2017

sdodson commented Sep 22, 2017

openshift-merge-robot commented Sep 22, 2017

ewolinetz commented Aug 25, 2017 •

edited

Loading

sdodson Sep 20, 2017 •

edited

Loading