Fix registry auth variable #5595
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is currently a bug in registry auth credential creation logic for openshift_node and openshift_node_upgrade This commit fixes the logic.
michaelgugino
requested review from
ashcrow,
abutcher,
sdodson and
mtnbikenc
openshift-ci-robot
added
the
size/XS
This was referenced Sep 29, 2017
|
/test |
|
/kind bug |
|
/LGTM |
ashcrow
approved these changes
Sep 29, 2017
|
flake openshift/origin#12072 |
|
/test upgrade |
mtnbikenc
approved these changes
Sep 29, 2017
|
/test upgrade |
|
/test all [submit-queue is verifying that this PR is safe to merge] |
|
Automatic merge from submit-queue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is currently a bug in registry auth
credential creation logic for openshift_node
and openshift_node_upgrade
This commit fixes the logic.