Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix registry auth variable #5595

Conversation

michaelgugino
Copy link
Contributor

There is currently a bug in registry auth
credential creation logic for openshift_node
and openshift_node_upgrade

This commit fixes the logic.

There is currently a bug in registry auth
credential creation logic for openshift_node
and openshift_node_upgrade

This commit fixes the logic.
@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Sep 29, 2017
@michaelgugino michaelgugino added the kind/bug Categorizes issue or PR as related to a bug. label Sep 29, 2017
@ashcrow
Copy link
Member

ashcrow commented Sep 29, 2017

/test

@ashcrow
Copy link
Member

ashcrow commented Sep 29, 2017

/kind bug

@ashcrow
Copy link
Member

ashcrow commented Sep 29, 2017

/LGTM

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 29, 2017
@ashcrow
Copy link
Member

ashcrow commented Sep 29, 2017

flake openshift/origin#12072

@ashcrow
Copy link
Member

ashcrow commented Sep 29, 2017

/test upgrade

@michaelgugino
Copy link
Contributor Author

/test upgrade

@openshift-merge-robot
Copy link
Contributor

/test all [submit-queue is verifying that this PR is safe to merge]

@openshift-merge-robot
Copy link
Contributor

Automatic merge from submit-queue.

@openshift-merge-robot openshift-merge-robot merged commit bc5eeed into openshift:master Sep 30, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants