openshift_checks: Fix incorrect list cast #5619
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
the
size/S
|
bot, retest this please |
|
Atomic failure is not related to this change. Issue is: |
sosiouxme
reviewed
Oct 2, 2017
| regs = self.get_var("openshift_docker_additional_registries", default=[]) | ||
| # https://bugzilla.redhat.com/show_bug.cgi?id=1497274 | ||
| # if the result was a string type, place it into a list. We must do this | ||
| # as using list() on a string will split the string into it's characters. |
There was a problem hiding this comment.
"its" :)
Not worth holding up the PR over.
There was a problem hiding this comment.
Need to check for openshift_deployment_type == 'openshift-enterprise' and addend the enterprise image registry.
docker_image_availability casted openshift_docker_additional_registries to a list using the list() function. If a string was returned (IE: only a single registry added) the result would be the string split up by component characters. This change forces a string result from get_var to be placed inside a list. If the result is anything BUT a string the original list() function is called on the result. Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1497274 Signed-off-by: Steve Milner <smilner@redhat.com>
|
/lgtm |
|
@sosiouxme agreed |
|
flake openshift/origin#16246 |
|
/test upgrade |
|
/test all [submit-queue is verifying that this PR is safe to merge] |
|
Automatic merge from submit-queue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
docker_image_availabilitycastedopenshift_docker_additional_registriesto a list using the
list()function. If a string was returned (IE: onlya single registry added) the result would be the string split up by
component characters. This change forces a string result from
get_vartobe placed inside a list. If the result is anything BUT a string the
original
list()function is called on the result.Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1497274
Resolves #5610