-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
openshift_checks: Fix incorrect list cast #5619
Conversation
bot, retest this please |
Atomic failure is not related to this change.
Issue is:
|
regs = self.get_var("openshift_docker_additional_registries", default=[]) | ||
# https://bugzilla.redhat.com/show_bug.cgi?id=1497274 | ||
# if the result was a string type, place it into a list. We must do this | ||
# as using list() on a string will split the string into it's characters. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"its" :)
Not worth holding up the PR over.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll fix it anyway 😆
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need to check for openshift_deployment_type == 'openshift-enterprise' and addend the enterprise image registry.
docker_image_availability casted openshift_docker_additional_registries to a list using the list() function. If a string was returned (IE: only a single registry added) the result would be the string split up by component characters. This change forces a string result from get_var to be placed inside a list. If the result is anything BUT a string the original list() function is called on the result. Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1497274 Signed-off-by: Steve Milner <smilner@redhat.com>
/lgtm |
@sosiouxme agreed |
flake openshift/origin#16246 |
/test upgrade |
/test all [submit-queue is verifying that this PR is safe to merge] |
Automatic merge from submit-queue. |
docker_image_availability
castedopenshift_docker_additional_registries
to a list using the
list()
function. If a string was returned (IE: onlya single registry added) the result would be the string split up by
component characters. This change forces a string result from
get_var
tobe placed inside a list. If the result is anything BUT a string the
original
list()
function is called on the result.Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1497274
Resolves #5610