Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Simplify dns management #5707

Closed
wants to merge 1 commit into from
Closed

Conversation

sdodson
Copy link
Member

@sdodson sdodson commented Oct 9, 2017

This relies on the node service configuring dnsmasq for all the zones
that the node should be responsible via dbus.

This removes all install time node specific configuration as well.

Relies on openshift/origin#16740

@openshift-ci-robot openshift-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 9, 2017
enable-dbus
bind-dynamic
except-interface=lo
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was thinking we might want to make except-interface configurable. Today it listens only on one interface (the public interface), however with bind-dynamic we will listen on every interface. Some users might have machines with multiple lans, and it might not be desireable for them to bind to those interfaces.

I would make this a template, accept a user-provided list, and join into a csv or space separated, not sure what dns mask takes here.

@openshift-ci-robot openshift-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 10, 2017
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 12, 2017
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 12, 2017
Switches dnsmasq to listen on all interfaces other than lo by default.
If you specify a list of interfaces to listen on it will use those
instead.

In 3.7 installs it relies on the node to send dbus messages eliminating
additional configuration files.

Some minor fixes to the dispatcher script to simplifying things.
@openshift-ci-robot
Copy link

@sdodson: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/openshift-jenkins/logging 9a3117b link /test logging
ci/openshift-jenkins/install 9a3117b link /test install
ci/openshift-jenkins/containerized 9a3117b link /test containerized
ci/openshift-jenkins/upgrade 9a3117b link /test upgrade
ci/openshift-jenkins/system-containers 9a3117b link /test system-containers

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@sdodson sdodson mentioned this pull request Oct 16, 2017
@sdodson sdodson closed this Oct 17, 2017
@sdodson sdodson mentioned this pull request Oct 17, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants