-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Simplify dns management #5707
Conversation
enable-dbus | ||
bind-dynamic | ||
except-interface=lo |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was thinking we might want to make except-interface configurable. Today it listens only on one interface (the public interface), however with bind-dynamic we will listen on every interface. Some users might have machines with multiple lans, and it might not be desireable for them to bind to those interfaces.
I would make this a template, accept a user-provided list, and join into a csv or space separated, not sure what dns mask takes here.
Switches dnsmasq to listen on all interfaces other than lo by default. If you specify a list of interfaces to listen on it will use those instead. In 3.7 installs it relies on the node to send dbus messages eliminating additional configuration files. Some minor fixes to the dispatcher script to simplifying things.
@sdodson: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
This relies on the node service configuring dnsmasq for all the zones
that the node should be responsible via dbus.
This removes all install time node specific configuration as well.
Relies on openshift/origin#16740