Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Secret/ConfigMap as optional bundle objects #25125

Merged
merged 1 commit into from
Sep 1, 2020
Merged

Add Secret/ConfigMap as optional bundle objects #25125

merged 1 commit into from
Sep 1, 2020

Conversation

adellape
Copy link
Contributor

@adellape adellape added this to the Next Release milestone Aug 28, 2020
@openshift-ci-robot openshift-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Aug 28, 2020
@openshift-docs-preview-bot
Copy link

The preview will be available shortly at:

@jboxman
Copy link
Contributor

jboxman commented Aug 28, 2020

@adellape LGTM based on today's styling guidelines

@adellape adellape added the peer-review-done Signifies that the peer review team has reviewed this PR label Aug 28, 2020
@adellape
Copy link
Contributor Author

@exdx PTAL for tech review. 🙇

xref:
operator-framework/operator-lifecycle-manager#1447
operator-framework/operator-lifecycle-manager#1434

@jianzhangbjz
Copy link

@yuhui-12 Could you help review/test it? Thanks!

exdx
exdx reviewed Aug 31, 2020
View reviewed changes
modules/olm-bundle-format.adoc Outdated Show resolved Hide resolved
modules/olm-bundle-format.adoc Outdated Show resolved Hide resolved
@openshift-ci-robot openshift-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Aug 31, 2020
@adellape
Copy link
Contributor Author

adellape commented Aug 31, 2020 •
edited
Loading

@exdx @jboxman Updated per latest feedback, which includes moving discussion about the optional objects to its own subsection so there's more room to discuss the lifecycle/workflow.

http://file.rdu.redhat.com/~adellape/082820/secret_configmap/operators/olm-packaging-format.html#olm-bundle-format-manifests_olm-packaging-format

exdx
exdx reviewed Aug 31, 2020
View reviewed changes
Copy link

@exdx exdx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM just a small typo on the wording

modules/olm-bundle-format.adoc Outdated Show resolved Hide resolved
modules/olm-bundle-format.adoc Outdated Show resolved Hide resolved
@exdx
Copy link

exdx commented Aug 31, 2020

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 31, 2020
@openshift-ci-robot
Copy link

New changes are detected. LGTM label has been removed.

@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Aug 31, 2020
adellape
adellape commented Aug 31, 2020
View reviewed changes
modules/olm-bundle-format.adoc
A bundle also includes an `annotations.yaml` file in its `metadata/` folder. This file
defines higher level aggregate data that helps describe the format and package
information about how the bundle should be added into an index of bundles:
A bundle also includes an `annotations.yaml` file in its `/metadata` directory.
Copy link
Contributor Author

@adellape adellape Aug 31, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated to /metadata to match the updated /manifests style.

@adellape adellape requested a review from yuhui-12 August 31, 2020 21:11
yuhui-12
yuhui-12 reviewed Sep 1, 2020
View reviewed changes
Copy link

@yuhui-12 yuhui-12 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@adellape adellape merged commit 6bc311e into openshift:master Sep 1, 2020
@adellape
Copy link
Contributor Author

adellape commented Sep 1, 2020

/cherrypick enterprise-4.6

@adellape
Copy link
Contributor Author

adellape commented Sep 1, 2020

/cherrypick enterprise-4.5

@openshift-cherrypick-robot
Copy link

@adellape: new pull request created: #25157

In response to this:

/cherrypick enterprise-4.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

This was referenced Sep 1, 2020
Merged
Merged
@openshift-cherrypick-robot
Copy link

@adellape: new pull request created: #25158

In response to this:

/cherrypick enterprise-4.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yuhui-12 yuhui-12 yuhui-12 left review comments

@exdx exdx exdx left review comments

@jboxman jboxman jboxman left review comments

Assignees

@exdx exdx

Labels
branch/enterprise-4.5 branch/enterprise-4.6 peer-review-done Signifies that the peer review team has reviewed this PR size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
Next Release
Development

Successfully merging this pull request may close these issues.
8 participants
@adellape @openshift-docs-preview-bot @jboxman @jianzhangbjz @exdx @openshift-ci-robot @openshift-cherrypick-robot @yuhui-12