Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OSDOCS-1630 - RHCOS bootupd overview #28071

Merged
merged 1 commit into from
Jan 18, 2021
Merged

Conversation

bobfuru
Copy link
Contributor

@bobfuru bobfuru commented Dec 11, 2020

OSDOCS-1630 (docs epic) tracking feature complete work for RHCOS bootupd in OCP 4.7, as described in GRPA-2895. The purpose of this PR is to include an overview of bootupd, and to determine whether additional task-based docs are required for RHCOS/OCP users.

PREVIEW LINKS
"Key RHCOS features":
https://osdocs-1630--ocpdocs.netlify.app/openshift-enterprise/latest/architecture/architecture-rhcos.html#rhcos-key-features_architecture-rhcos

Manual enable/machine config methods:
https://osdocs-1630--ocpdocs.netlify.app/openshift-enterprise/latest/architecture/architecture-rhcos.html#architecture-rhcos-updating-bootloader.adoc_architecture-rhcos

@cgwalters @ashcrow
This is a relatively new realm for me, so I've been reading up on https://github.com/coreos/bootupd/ and related discussions. I'm trying to determine whether a mention of bootupd in the "Key RHCOS features" list is sufficient, or if I should build this out as a larger section, possibly with commands.

From an OCP user's perspective, I have some open questions that I am seeking your input on:

  • Is it enough to be telling users that bootupd is enabled by default? Anything else they need to do to enable bootupd?
  • Assuming this runs in background, should we describe how often and when firmware and bootloader updates happen?
  • Can a cluster admin perform any bootupd commands/updates via CLI? For example, borrowing from fwupd examples, are there commands that we want to document for bootupd? Such as:
The following commands allow you to check for updates on a device with firmware supported by bootupd.

To display all devices detected by bootupd:
# bootupd get-devices

To download the latest metadata from bootupd:
# bootupd refresh

To see if you have updates available for any devices on the system:
#bootupd get-updates

To download and apply all updates for your system:
# bootupd update

Any feedback is greatly appreciated, thanks!

@bobfuru bobfuru added this to the Future Release milestone Dec 11, 2020
@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Dec 11, 2020
@openshift-docs-preview-bot

The preview will be available shortly at:

@ashcrow
Copy link
Member

ashcrow commented Dec 14, 2020

From an OCP user's perspective, I have some open questions that I am seeking your input on:

* Is it enough to be telling users that bootupd is enabled by default? Anything else they need to do to enable bootupd?

* Assuming this runs in background, should we describe how often and when firmware and bootloader updates happen?

My $0.02 is that we should not as it is meant to run with OCP update process. Noting it's new and enabled in 4.7 should be enough IMHO.

* Can a cluster admin perform any bootupd commands/updates via CLI? For example, borrowing from [fwupd](https://github.com/fwupd/fwupd/) examples, are there commands that we want to document for bootupd? Such as:

Can they? Yes. Should they? Probably not. It should be done as part of the OCP update process. Similar to how one could run rpm-ostree commands on the host but they generally should let the product handle it.

However, pointing over to the bootupd project for folks to learn more would be nice for those interested.

@cgwalters Your thoughts?

@cgwalters
Copy link
Member

cgwalters commented Dec 14, 2020

My $0.02 is that we should not as it is meant to run with OCP update process.

Well we...aren't doing that right now by default. Lots of discussion in coreos/bootupd#8 and coreos/fedora-coreos-docs#203

(And ideally I was hoping that we could keep FCOS/RHCOS in sync regarding this - the FCOS docs PR hasn't merged because the latest bootupd isn't in FCOS stable because of coreos/fedora-coreos-tracker#649 )

I think basically for 4.7 (same as FCOS) we are just saying this is something one can run manually for now, or provide a MachineConfig with the simple systemd unit. And note that we may automate it in the future.

@bobfuru
Copy link
Contributor Author

bobfuru commented Dec 14, 2020

Thanks for the comments, @cgwalters. I wasn't aware of coreos/fedora-coreos-docs#2. I'll take that and the other conversation into consideration and figure out how to get this PR updated.

@openshift-ci-robot openshift-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Dec 16, 2020
@openshift-ci-robot openshift-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Dec 16, 2020
@bobfuru
Copy link
Contributor Author

bobfuru commented Dec 16, 2020

However, pointing over to the bootupd project for folks to learn more would be nice for those interested.

I'd like to avoid the upstream docs as there are likely to be parity and maintenance issues between the 2 sets.

I think basically for 4.7 (same as FCOS) we are just saying this is something one can run manually for now, or provide a MachineConfig with the simple systemd unit. And note that we may automate it in the future.

I've made a few revisions so that we have a general overview in the "Key RHCOS features" section, plus steps for how to enable bootupd via bootctl or machine config later on in the same page but as a distinct module taken from the FCOS docs PR (coreos/fedora-coreos-docs#203).

I'd also like to avoid making statements that predict future availability.

@bobfuru
Copy link
Contributor Author

bobfuru commented Dec 16, 2020

@cgwalters and @ashcrow - I'd like your feedback on the manual install/MachineConfig instructions I've added. Not sure if you had it in mind that we should include that level of detail or not. Thanks.

@bobfuru
Copy link
Contributor Author

bobfuru commented Jan 6, 2021

@cgwalters and @ashcrow - Bump, PTAL and let me know if you have any additional feedback or if this looks good to you.
Preview here

modules/rhcos-about.adoc Outdated Show resolved Hide resolved
@bobfuru bobfuru added the peer-review-needed Signifies that the peer review team needs to review this PR label Jan 11, 2021
@bobfuru
Copy link
Contributor Author

bobfuru commented Jan 11, 2021

@openshift/team-documentation PTAL

modules/architecture-rhcos-updating-bootloader.adoc Outdated Show resolved Hide resolved
modules/architecture-rhcos-updating-bootloader.adoc Outdated Show resolved Hide resolved
modules/architecture-rhcos-updating-bootloader.adoc Outdated Show resolved Hide resolved
modules/architecture-rhcos-updating-bootloader.adoc Outdated Show resolved Hide resolved
modules/architecture-rhcos-updating-bootloader.adoc Outdated Show resolved Hide resolved
modules/rhcos-about.adoc Outdated Show resolved Hide resolved
modules/architecture-rhcos-updating-bootloader.adoc Outdated Show resolved Hide resolved
@kalexand-rh kalexand-rh added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-needed Signifies that the peer review team needs to review this PR labels Jan 11, 2021
@openshift-ci-robot openshift-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 11, 2021
@bobfuru bobfuru merged commit 9edc8cf into openshift:master Jan 18, 2021
@bobfuru
Copy link
Contributor Author

bobfuru commented Jan 18, 2021

/cherrypick enterprise-4.7

@openshift-cherrypick-robot
Copy link

openshift-cherrypick-robot commented Jan 18, 2021

@bobfuru: new pull request created: #28658

In response to this:

/cherrypick enterprise-4.7

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
branch/enterprise-4.7 peer-review-done Signifies that the peer review team has reviewed this PR size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

9 participants