Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WMCO 2.0.0 release notes #29589

Merged
merged 1 commit into from
Mar 2, 2021
Merged

WMCO 2.0.0 release notes #29589

merged 1 commit into from
Mar 2, 2021

Conversation

codyhoag
Copy link
Contributor

@codyhoag codyhoag commented Feb 18, 2021 •
edited
Loading

@codyhoag codyhoag added this to the Future Release milestone Feb 18, 2021
@openshift-ci-robot openshift-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Feb 18, 2021
@codyhoag
Copy link
Contributor Author

Build is failing due to an xref to content that will be merged in #28832

@netlify
Copy link

netlify bot commented Feb 18, 2021 •
edited
Loading

Deploy preview for osdocs ready!

Built with commit 16728b4

https://deploy-preview-29589--osdocs.netlify.app

@codyhoag
Copy link
Contributor Author

/hold

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 18, 2021
aravindhp
aravindhp reviewed Feb 18, 2021
View reviewed changes
Copy link

@aravindhp aravindhp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this, @codyhoag

windows_containers/windows-containers-release-notes-2-x.adoc Show resolved Hide resolved
windows_containers/windows-containers-release-notes-2-x.adoc Outdated Show resolved Hide resolved
@codyhoag
Copy link
Contributor Author

@sgaoshang can you confirm the release notes for WMCO 2.0.0? There is one pending issue with the AWS image version, which is captured in some comments in this PR. Everything else is finished. Thanks!

@codyhoag codyhoag force-pushed the wmco-rns-2-0 branch 3 times, most recently from d919d15 to f1b9ddb Compare March 1, 2021 22:01
@codyhoag codyhoag added the peer-review-needed Signifies that the peer review team needs to review this PR label Mar 1, 2021
@pneedle-rh pneedle-rh self-requested a review March 2, 2021 09:07
@codyhoag
Copy link
Contributor Author

codyhoag commented Mar 2, 2021

Confirmed by QE via Slack.

@codyhoag codyhoag removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 2, 2021
pneedle-rh
pneedle-rh reviewed Mar 2, 2021
View reviewed changes
Copy link
Contributor

@pneedle-rh pneedle-rh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@codyhoag I have now completed my review. I have added a few minor suggestions. Aside from those, this LGTM!

windows_containers/windows-containers-release-notes-2-x.adoc Outdated Show resolved Hide resolved
windows_containers/windows-containers-release-notes-2-x.adoc Show resolved Hide resolved
windows_containers/windows-containers-release-notes-2-x.adoc Outdated Show resolved Hide resolved
windows_containers/windows-containers-release-notes-2-x.adoc Outdated Show resolved Hide resolved
windows_containers/windows-containers-release-notes-2-x.adoc Outdated Show resolved Hide resolved
windows_containers/windows-containers-release-notes-2-x.adoc Outdated Show resolved Hide resolved
windows_containers/windows-containers-release-notes-2-x.adoc Outdated Show resolved Hide resolved
windows_containers/windows-containers-release-notes-2-x.adoc Outdated Show resolved Hide resolved
@pneedle-rh pneedle-rh added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-needed Signifies that the peer review team needs to review this PR labels Mar 2, 2021
@codyhoag codyhoag merged commit 7cd4d26 into openshift:master Mar 2, 2021
@codyhoag
Copy link
Contributor Author

codyhoag commented Mar 2, 2021

/cherrypick enterprise-4.8

@openshift-cherrypick-robot
Copy link

@codyhoag: new pull request created: #29999

In response to this:

/cherrypick enterprise-4.8

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Mar 2, 2021
Merged
@codyhoag
Copy link
Contributor Author

codyhoag commented Mar 2, 2021

/cherrypick enterprise-4.7

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Mar 2, 2021
Merged
@openshift-cherrypick-robot
Copy link

@codyhoag: new pull request created: #30000

In response to this:

/cherrypick enterprise-4.7

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aravindhp aravindhp aravindhp left review comments

@pneedle-rh pneedle-rh pneedle-rh left review comments

@aburdenthehand aburdenthehand Awaiting requested review from aburdenthehand

@jeana-redhat jeana-redhat Awaiting requested review from jeana-redhat

@vikram-redhat vikram-redhat Awaiting requested review from vikram-redhat

Assignees
No one assigned
Labels
branch/enterprise-4.7 branch/enterprise-4.8 peer-review-done Signifies that the peer review team has reviewed this PR size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
Next Release
Development

Successfully merging this pull request may close these issues.
6 participants
@codyhoag @openshift-cherrypick-robot @aravindhp @pneedle-rh @vikram-redhat @openshift-ci-robot