Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OSDOCS-2358: release notes for custom error code response pages #36498

Merged
merged 1 commit into from
Oct 1, 2021
Merged

OSDOCS-2358: release notes for custom error code response pages #36498

merged 1 commit into from
Oct 1, 2021

Conversation

skrthomas
Copy link
Contributor

@skrthomas skrthomas commented Sep 17, 2021 •
edited
Loading

@openshift-ci openshift-ci bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Sep 17, 2021
@netlify
Copy link

netlify bot commented Sep 17, 2021 •
edited
Loading

✔️ Deploy Preview for osdocs ready!

🔨 Explore the source changes: 3f98887

🔍 Inspect the deploy log: https://app.netlify.com/sites/osdocs/deploys/6157523227b7f500072f31b3

😎 Browse the preview: https://deploy-preview-36498--osdocs.netlify.app/openshift-enterprise/latest/release_notes/ocp-4-9-release-notes

@openshift-ci openshift-ci bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 21, 2021
@skrthomas skrthomas force-pushed the OSDOCS-2358-rn branch 2 times, most recently from 3287eb5 to 9efa6ad Compare September 21, 2021 17:27
@skrthomas skrthomas mentioned this pull request Sep 21, 2021
Merged
miheer
miheer suggested changes Sep 23, 2021
View reviewed changes
@jechen0648
Copy link

https://issues.redhat.com/browse/OSDOCS-2358

For 4.9

Known Issue: https://deploy-preview-36498--osdocs.netlify.app/openshift-enterprise/latest/release_notes/ocp-4-9-release-notes?utm_source=github&utm_campaign=bot_dp#ocp-4-9-known-issues

Preview: https://deploy-preview-36498--osdocs.netlify.app/openshift-enterprise/latest/release_notes/ocp-4-9-release-notes?utm_source=github&utm_campaign=bot_dp#ocp-4-9-networking

@miheer @jechen0648 ready for QA.

From this preview for ocp-4-8-networking, I saw under "Customizing HAProxy error code response pages" section, there is "For more information, see Customizing HAProxy error code response pages", if I click on hyperlink for "Customizing HAProxy error code response pages", it leads me to page: https://deploy-preview-36498--osdocs.netlify.app/openshift-enterprise/latest/networking/ingress-operator.html#nw-customize-ingress-error-pages_configuring-ingress, and in this page, I do not see any place describe how to customize HAProxy error code response pages. Did I look at wrong place?

@openshift-ci openshift-ci bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 29, 2021
@jechen0648
Copy link

https://issues.redhat.com/browse/OSDOCS-2358
For 4.9
Known Issue: https://deploy-preview-36498--osdocs.netlify.app/openshift-enterprise/latest/release_notes/ocp-4-9-release-notes?utm_source=github&utm_campaign=bot_dp#ocp-4-9-known-issues
Preview: https://deploy-preview-36498--osdocs.netlify.app/openshift-enterprise/latest/release_notes/ocp-4-9-release-notes?utm_source=github&utm_campaign=bot_dp#ocp-4-9-networking
@miheer @jechen0648 ready for QA.

From this preview for ocp-4-8-networking, I saw under "Customizing HAProxy error code response pages" section, there is "For more information, see Customizing HAProxy error code response pages", if I click on hyperlink for "Customizing HAProxy error code response pages", it leads me to page: https://deploy-preview-36498--osdocs.netlify.app/openshift-enterprise/latest/networking/ingress-operator.html#nw-customize-ingress-error-pages_configuring-ingress, and in this page, I do not see any place describe how to customize HAProxy error code response pages. Did I look at wrong place?

Thanks for clarification from Sara, this PR looks good to me.

@jechen0648
Copy link

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 29, 2021
@openshift-ci openshift-ci bot removed lgtm Indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Oct 1, 2021
@skrthomas skrthomas force-pushed the OSDOCS-2358-rn branch 5 times, most recently from ab36a64 to 81f38a2 Compare October 1, 2021 18:21
mikemckiernan
mikemckiernan reviewed Oct 1, 2021
View reviewed changes
Copy link
Contributor

@mikemckiernan mikemckiernan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@mikemckiernan mikemckiernan merged commit 069b5bb into openshift:enterprise-4.9 Oct 1, 2021
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 1, 2021
@skrthomas
Copy link
Contributor Author

#33497 (RN Tracker)

This was referenced Oct 13, 2021
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikemckiernan mikemckiernan mikemckiernan left review comments

@miheer miheer miheer requested changes

Assignees

@mikemckiernan mikemckiernan

@jechen0648 jechen0648

Labels
lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@skrthomas @jechen0648 @miheer @mikemckiernan