[dedicated-3.7] Use an annotation to provide a route cookie #5390
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Route annotation: router.openshift.io/router.cookie.name can be used to set a cookie name for the route. Added ROUTER_COOKIE_NAME for setting cookie name for all routes. The cookie must pass regex filter "[a-zA-Z0-9_-]+" https://trello.com/c/dZpU26W9 (3) Allow routes to set the cookie names for session stickiness origin PR 16454 openshift/origin#16454 (cherry picked from commit 4971e9d)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Route annotation:
router.openshift.io/router.cookie.name
can be used to set a cookie name for the route.
Added ROUTER_COOKIE_NAME for setting cookie name for all routes.
The cookie must pass regex filter "[a-zA-Z0-9_-]+"
https://trello.com/c/dZpU26W9
(3) Allow routes to set the cookie names for session stickiness
origin PR 16454
openshift/origin#16454
(cherry picked from commit 4971e9d)
#5309