-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OCPBUGS#10640: Added clarification point to disk partition BM doc #67707
Conversation
@dfitzmau: This pull request references Jira Issue OCPBUGS-10640, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@dfitzmau: No Jira issue is referenced in the title of this pull request. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
🤖 Tue Mar 19 17:09:23 - Prow CI generated the docs preview: |
bae3f05
to
e2e3c7b
Compare
9fbda97
to
77f1bdc
Compare
That doesn't quite cut it for me. Just as a reminder: Thus, in the default configuration, nodefs monitors /, imagefs monitors /. My issues with the doc:
|
I don't know if this is true. I don't think Kubelet will ever stop monitoring the root disk. It will monitor the disk that /var/lib/kubelet is on and consider that the root filesystem. So pods, volumes, ephemeral storage and logs will be on this filesystem.
This is correct. The other issue we should keep in mind is that we may allow users to modify the location for /var/lib/containers. They can change the graphroot in storage.conf. I wrote an upstream blog post about this. Currently we don't really provide support for it but I just want to bring more awareness to this fact. The blog post I wrote (which is still WIP) is here |
Thanks, @kannon92 , @andreaskaris , and @djuran . From reading the comments, I'll take it the bullet points under "There are two cases where you might want to override the default partitioning when installing RHCOS on an OpenShift Container Platform cluster node:" are problematic and need to be removed and replaced with suggestive text that points towards mounting |
77f1bdc
to
0fc4007
Compare
So some of the confusion might be coming from my wording, and if so, I'm sorry about that. What I mean to say is that (and correct me if I'm wrong): kubelet considers the root filesystem the disk that /var/lib/kubelet is on. |
That is all correct. |
0fc4007
to
9f1cc7a
Compare
9f1cc7a
to
acf7c9f
Compare
Hi @andreaskaris and @kannon92 , I updated the PR based on your feedback. I'm not too versed in OCP storage components, so please feel free to suggest better sentences. I assume I should remove the https://access.redhat.com/solutions/5587281 link for 4.14 + docs as it applies to RHEL 8? As this section is highly confusing its current format, maybe simplifying it would be better? |
/retest |
991a118
to
3995d66
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple of suggestions. Nice job! (Added labels but wasn't sure about 4.16, so didn't add that one.)
@dfitzmau: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
/lgtm |
/label merge-review-needed |
/remove-label merge-review-needed |
/cherrypick enterprise-4.14 |
/cherrypick enterprise-4.15 |
/cherrypick enterprise-4.16 |
@ShaunaDiaz: new pull request created: #73615 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@ShaunaDiaz: new pull request created: #73616 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@ShaunaDiaz: new pull request created: #73617 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
OCPBUGS-10640
Version(s):
4.16, 4.15 and 4.14
For 4.13 and 4.12, ensure you do not remove:
Link to docs preview:
Disk partioning
Additional information: