Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OBSDOCS-932: Add clarifications about storage in the Tempo docs #73716

Merged
merged 1 commit into from
Apr 8, 2024
Merged

OBSDOCS-932: Add clarifications about storage in the Tempo docs #73716

merged 1 commit into from
Apr 8, 2024

Conversation

max-cx
Copy link
Contributor

@max-cx max-cx commented Mar 25, 2024 •
edited
Loading

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Mar 25, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Mar 25, 2024 •
edited by openshift-ci bot
Loading

@max-cx: This pull request references OBSDOCS-932 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.16.0" version, but no target version was set.

In response to this:

Version(s):

Issue:

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Mar 25, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Mar 25, 2024 •
edited by openshift-ci bot
Loading

@max-cx: This pull request references OBSDOCS-932 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.16.0" version, but no target version was set.

In response to this:

Version(s):

4.16, 4.15, 4.14, 4.13, 4.12

Issue:

https://issues.redhat.com/browse/OBSDOCS-932

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Mar 25, 2024 •
edited
Loading

🤖 Mon Apr 08 14:11:17 - Prow CI generated the docs preview:

https://73716--ocpdocs-pr.netlify.app/
https://73716--ocpdocs-pr.netlify.app/openshift-enterprise/latest/observability/distr_tracing/distr_tracing_tempo/distr-tracing-tempo-installing.html

@rohennes rohennes mentioned this pull request Mar 25, 2024
Open
@openshift-ci-robot
Copy link

openshift-ci-robot commented Mar 25, 2024 •
edited by openshift-ci bot
Loading

@max-cx: This pull request references OBSDOCS-932 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.16.0" version, but no target version was set.

In response to this:

Version(s):

4.16, 4.15, 4.14, 4.13, 4.12

Issue:

https://issues.redhat.com/browse/OBSDOCS-932

Link to docs preview:

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Mar 25, 2024 •
edited by openshift-ci bot
Loading

@max-cx: This pull request references OBSDOCS-932 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.16.0" version, but no target version was set.

In response to this:

Version(s):

4.16, 4.15, 4.14, 4.13, 4.12

Issue:

https://issues.redhat.com/browse/OBSDOCS-932

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Mar 27, 2024 •
edited by openshift-ci bot
Loading

@max-cx: This pull request references OBSDOCS-932 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.16.0" version, but no target version was set.

In response to this:

Version(s):

4.16, 4.15, 4.14, 4.13, 4.12

Issue:

https://issues.redhat.com/browse/OBSDOCS-932

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@max-cx
Copy link
Contributor Author

max-cx commented Mar 27, 2024

/label peer-review-needed

@openshift-ci openshift-ci bot added the peer-review-needed Signifies that the peer review team needs to review this PR label Mar 27, 2024
@michaelryanpeter
Copy link
Contributor

/label peer-review-in-progress

@michaelryanpeter michaelryanpeter added this to the Continuous Release milestone Mar 27, 2024
@openshift-ci openshift-ci bot added the peer-review-in-progress Signifies that the peer review team is reviewing this PR label Mar 27, 2024
michaelryanpeter
michaelryanpeter reviewed Mar 27, 2024
View reviewed changes
Copy link
Contributor

@michaelryanpeter michaelryanpeter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly minimalism suggestions and a couple of minor style issues.

/label peer-review-done
/remove-label peer-review-in-progress
/remove-label peer-review-needed

modules/distr-tracing-tempo-install-cli.adoc Outdated Show resolved Hide resolved
modules/distr-tracing-tempo-install-web-console.adoc Outdated Show resolved Hide resolved
modules/distr-tracing-tempo-install-web-console.adoc Outdated Show resolved Hide resolved
modules/distr-tracing-tempo-install-cli.adoc Outdated Show resolved Hide resolved
modules/distr-tracing-tempo-install-cli.adoc Outdated Show resolved Hide resolved
modules/distr-tracing-tempo-install-web-console.adoc Outdated Show resolved Hide resolved
snippets/distr-tracing-tempo-secret-example.adoc Outdated Show resolved Hide resolved
@openshift-ci openshift-ci bot added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-in-progress Signifies that the peer review team is reviewing this PR peer-review-needed Signifies that the peer review team needs to review this PR labels Mar 27, 2024
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Apr 8, 2024

@max-cx: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@max-cx
Copy link
Contributor Author

max-cx commented Apr 8, 2024

/label merge-review-needed

@openshift-ci openshift-ci bot added the merge-review-needed Signifies that the merge review team needs to review this PR label Apr 8, 2024
@stevsmit stevsmit merged commit f61555a into openshift:main Apr 8, 2024
2 checks passed
@stevsmit
Copy link
Member

stevsmit commented Apr 8, 2024

/cherry-pick enterprise-4.12

@stevsmit
Copy link
Member

stevsmit commented Apr 8, 2024

/cherry-pick enterprise-4.13

@stevsmit
Copy link
Member

stevsmit commented Apr 8, 2024

/cherry-pick enterprise-4.14

@stevsmit
Copy link
Member

stevsmit commented Apr 8, 2024

/cherry-pick enterprise-4.15

@stevsmit
Copy link
Member

stevsmit commented Apr 8, 2024

/cherry-pick enterprise-4.16

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Apr 8, 2024
Merged
@openshift-cherrypick-robot
Copy link

@stevsmit: new pull request created: #74371

In response to this:

/cherry-pick enterprise-4.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot
Copy link

@stevsmit: new pull request created: #74372

In response to this:

/cherry-pick enterprise-4.13

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Apr 8, 2024
Merged
@openshift-cherrypick-robot
Copy link

@stevsmit: new pull request created: #74373

In response to this:

/cherry-pick enterprise-4.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Apr 8, 2024
Merged
@openshift-cherrypick-robot
Copy link

@stevsmit: new pull request created: #74374

In response to this:

/cherry-pick enterprise-4.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Apr 8, 2024
Merged
@openshift-cherrypick-robot
Copy link

@stevsmit: new pull request created: #74375

In response to this:

/cherry-pick enterprise-4.16

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Apr 8, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ocpdocs-vale-bot ocpdocs-vale-bot ocpdocs-vale-bot left review comments

@michaelryanpeter michaelryanpeter michaelryanpeter left review comments

@IshwarKanse IshwarKanse IshwarKanse approved these changes

@iblancasa iblancasa iblancasa approved these changes

@rubenvp8510 rubenvp8510 rubenvp8510 approved these changes

@andreasgerstmayr andreasgerstmayr andreasgerstmayr approved these changes

Assignees
No one assigned
Labels
branch/enterprise-4.12 branch/enterprise-4.13 branch/enterprise-4.14 branch/enterprise-4.15 branch/enterprise-4.16 jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. merge-review-needed Signifies that the merge review team needs to review this PR peer-review-done Signifies that the peer review team has reviewed this PR size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
Continuous Release
Development

Successfully merging this pull request may close these issues.