Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Persistent Volume Claim Protection #7497

Conversation

pospispa
Copy link

@pospispa pospispa commented Feb 2, 2018

PVC Protection alpha feature was added to K8s 1.9 in PRs:

and documented in K8s 1.9 in PR:

That's why the PVC Protection is a new alpha feature in OpenShift 3.9 and that's why PVC Protection documentation is added.

Target OpenShift version: 3.9+

@jsafrane @openshift/team-documentation PTAL

@openshift-ci-robot openshift-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Feb 2, 2018
@@ -0,0 +1,58 @@
[[install-config-configuring-pvc-protection]]
= Configuring for Persistent Volume Protection
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Persistent Volume Claim Protection

- PVCProtection=true
----

. On all masters and nodes, restart OpenShift for the changes to take effect:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Double colon at the end suggests that there is something missing.

PVC Protection alpha feature was added to K8s 1.9 in PRs:
- kubernetes/kubernetes#55824
- kubernetes/kubernetes#55873

and documented in K8s 1.9 in PR:
- kubernetes/website#6415

That's why the PVC Protection is a new alpha feature in OpenShift 3.9 and that's why PVC Protection documentation is added.
@pospispa pospispa force-pushed the 566-postpone-pvc-deletion-if-used-in-a-pod branch from c99a871 to 9270841 Compare February 3, 2018 08:39
@vikram-redhat
Copy link
Contributor

@vikram-redhat
Copy link
Contributor

@pospispa - would this apply to online and dedicated branches as well?

@jsafrane
Copy link
Contributor

jsafrane commented Feb 5, 2018

yes, it applies to Online and Dedicated, however not until the feature is either manually enabled by us or it becomes enabled by default (probably in 3.10).

@openshift-bot openshift-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 17, 2018
@openshift-bot
Copy link

@pospispa: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@vikram-redhat
Copy link
Contributor

@pospispa @jsafrane @tmorriso-rh

This has now been picked into the master and 3.9 branches via this: #7867 and this: #7905.

When this code has been backported to 3.6 and 3.7 branches and online and dedicated please let us know. Note that since there are no install instructions for online and dedicated, these instructions may need to be modified to reflect that.

@vikram-redhat
Copy link
Contributor

I forgot to add, we can now close this PR, which I am doing now.

@vikram-redhat vikram-redhat removed branch/enterprise-3.9 needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 23, 2018
@vikram-redhat vikram-redhat removed this from the Future Release milestone Feb 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants