-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New Provisioned Service Details page and Edit Action for Plan/Configuration/Bindings #52
Merged
Merged
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Binary file modified
BIN
-3.43 KB
(90%)
web-console/3-project-details/img/provisioned-service-collapsed.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
56 changes: 56 additions & 0 deletions
56
web-console/3-project-details/provisioned-service-details.md
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,56 @@ | ||
# Provisioned Service Details | ||
|
||
- Provisioned Services are those services provisioned from the Service Catalog and should be displayed | ||
- Some Provisioned Service info will be shown on the Project Overview page. For details on the collapsed and expanded list views see [Provisioned Services on the Overview](http://openshift.github.io/openshift-origin-design/web-console/3-project-details/provisioned-services-overview). | ||
|
||
## Navigating to Provisioned Service Details | ||
![template](img/v2-02.png) | ||
- Provisioned Services will be a primary navigation item below Resources. | ||
- **Note:** The icon for Provisioned Services is TBD and screenshots currently include a placeholder icon that will not be used. | ||
- There will be a landing page for a list of all Provisioned Services, where users can select from the list of Names to enter into the Details view of a particular provisioned service. will Selecting the a provisioned service from the | ||
- The standard landing page filter should be available at the top of the table. | ||
- The columns included are the name (link to details page), instance name, number of bindings, status, created date/time, and the Web Interface URL. | ||
|
||
![template](img/v2-03.png) | ||
- Users can also jump directly to a specific provisioned service by clicking on the link available in the list view on the Project Overview. | ||
- Some of the Provisioned service actions are also available from the Overview page via the kebab menu. | ||
|
||
## Details Page | ||
![template](img/v2-04.png) | ||
- The top of the provisioned service details page should have the standard breadcrumbs, large service name and smaller instance name in grey, as well as any tags that correspond to the service below the name. | ||
- The tabs available will be Details, Events, and Status. | ||
- On the Details tab, sections will include: | ||
1. Plan: Display the name of the plan followed by any description and feature information below. | ||
2. Configuration: Display all configuration parameters with corresponding disguised values to the right. | ||
- **Implementation Details:** The Reveal Values link should be left aligned above the parameters and should function the same as the "Reveal Secrets" link works to show all hidden values below. | ||
3. Bindings: | ||
- Visit [Binding Details](http://openshift.github.io/openshift-origin-design/web-console/5-components/binding-details) for more information on what to display in this section. | ||
- **Note:** Bindings are shown to the right but for smaller viewports this section will fall below the Configuration section as needed. | ||
|
||
### Edit Plan/ Configuration | ||
- Clicking the "Edit" button in the top right corner of the Details page will allow a user to edit the current Plan and/or Configuration shown. | ||
- **Note:** This Edit action is also available from the Overview via the kebab menu and the same wizard steps will apply on that page. | ||
|
||
![template](img/v2-05.png) | ||
- The same wizard initially used to order this Provisioned Service will appear with the current plan selected. | ||
- Users can click next if they wish to keep the current plan and simply edit the configuration parameters on the next step OR users can select a new plan using the radio button plan options on the right. | ||
|
||
![template](img/v2-06.png) | ||
- When a user selects a new plan, configuration parameters will be carried over to the new plan if possible. | ||
- Some required fields may not translate across plans. Display a warning at the top to notify users there are required fields that must be filled out in order to continue. | ||
- **Note:** The save button should be greyed out if required information is missing. The save button should also be greyed out if the user did not made changes on either step (Plan or Configuration). | ||
|
||
![template](img/v2-07.png) | ||
- Results should provide status of the changes regarding the plan and/or configuration. | ||
- Include an informational inline notification to notify users that any Bindings that previously existed will be carried over. | ||
|
||
### Actions Menu and Inline Actions | ||
![template](img/v2-08.png) | ||
- General Actions will appear in the "Actions" dropdown including edit YAML, Create Binding, Delete Binding, and Delete (Deprovision). | ||
- Inline actions are available for each Binding listed in the Bindings section. | ||
- The Edit link will be available if the binding has parameters associated with it. | ||
|
||
![template](img/v2-09.png) | ||
- This Edit action will bring up the current wizard component with the "Parameters" step showing all Binding parameters and values as editable fields. | ||
- The Save action will become available once a change has been made. | ||
- The results step should provide the confirmation/ status message once parameters have been updated. |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,8 @@ | ||
|
||
# Provisioned Services | ||
|
||
- Provisioned Services are those services provisioned from the Service Catalog. | ||
- Provisioned Services are summarized on the Project Overview page and detailed on the Provisioned Service pages. | ||
|
||
- Documentation for [Provisioned Services on the Overview](http://openshift.github.io/openshift-origin-design/web-console/3-project-details/provisioned-services-overview) | ||
- Documentation for [Provisioned Service Details](http://openshift.github.io/openshift-origin-design/web-console/3-project-details/provisioned-service-details) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The above image does not include the circle icon mentioned here. Is that the intended appearance?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point @cshinn, I was lazy and didn't update the image :)