Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Handle and return errors for metrics registration #31

Closed
wants to merge 2 commits into from
Closed

[WIP] Handle and return errors for metrics registration #31

wants to merge 2 commits into from

Conversation

fahlmant
Copy link
Contributor

Properly handles errors during the registration of metrics.

@fahlmant fahlmant changed the title Handle and return errors for metrics registration [WIP] Handle and return errors for metrics registration Jul 27, 2020
@openshift-ci-robot openshift-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 27, 2020
@2uasimojo
Copy link
Member

I have looked at this. It lgtm. Are we on /hold for test coverage?

@fahlmant
Copy link
Contributor Author

@2uasimojo I'm testing, and the logs aren't done yet. It currently just says "Something"

@fahlmant
Copy link
Contributor Author

Closing PR until further testing is done

@fahlmant fahlmant closed this Jul 27, 2020
@2uasimojo 2uasimojo mentioned this pull request Aug 1, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rafael-azevedo rafael-azevedo Awaiting requested review from rafael-azevedo

Assignees
No one assigned
Labels
do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@fahlmant @2uasimojo @openshift-ci-robot