Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] OCPBUGS-31547: UPSTREAM: <carry>: disable collect-profiles cronjob #730

Conversation

perdasilva
Copy link
Contributor

We've made some significant perf improvements in the last release and this job is challenging to maintain. Disabling it for now, but leaving the bits to potentially serve it if we want to manually configure the job on a customer cluster.

For the microshift manifests, deleting the manifest entirely because there is no cvo for microshift

@perdasilva perdasilva changed the title UPSTREAM: <carry>: disable collect-profiles cronjob OCPBUGS-31547: UPSTREAM: <carry>: disable collect-profiles cronjob Apr 10, 2024
@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. labels Apr 10, 2024
@openshift-ci-robot
Copy link

@perdasilva: This pull request references Jira Issue OCPBUGS-31547, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.16.0) matches configured target version for branch (4.16.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

No GitHub users were found matching the public email listed for the QA contact in Jira (jiazha@redhat.com), skipping review request.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

We've made some significant perf improvements in the last release and this job is challenging to maintain. Disabling it for now, but leaving the bits to potentially serve it if we want to manually configure the job on a customer cluster.

For the microshift manifests, deleting the manifest entirely because there is no cvo for microshift

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@perdasilva
Copy link
Contributor Author

This is a clone + (possible) fix of #724

@perdasilva perdasilva changed the title OCPBUGS-31547: UPSTREAM: <carry>: disable collect-profiles cronjob [WIP] OCPBUGS-31547: UPSTREAM: <carry>: disable collect-profiles cronjob Apr 10, 2024
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 10, 2024
@openshift-ci openshift-ci bot requested review from grokspawn and tmshort April 10, 2024 14:19
Copy link
Contributor

openshift-ci bot commented Apr 10, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: perdasilva

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 10, 2024
@perdasilva
Copy link
Contributor Author

/retest

1 similar comment
@tmshort
Copy link
Contributor

tmshort commented Apr 11, 2024

/retest

@perdasilva perdasilva force-pushed the disable-collectprofiles-perdasilva branch from 69af88e to 3170df8 Compare April 11, 2024 14:55
@perdasilva
Copy link
Contributor Author

/retest

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 16, 2024
@everettraven
Copy link
Contributor

/retest

@tmshort
Copy link
Contributor

tmshort commented Apr 25, 2024

The tests are failing pretty early, all with the same reason.

@ankitathomas
Copy link
Contributor

/retest

Signed-off-by: Per Goncalves da Silva <pegoncal@redhat.com>
@perdasilva perdasilva force-pushed the disable-collectprofiles-perdasilva branch from 3170df8 to 993d836 Compare July 16, 2024 07:19
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 16, 2024
Copy link
Contributor

openshift-ci bot commented Jul 16, 2024

@perdasilva: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-gcp-olm-flaky 993d836 link false /test e2e-gcp-olm-flaky
ci/prow/e2e-gcp-ovn 993d836 link true /test e2e-gcp-ovn

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@perdasilva perdasilva closed this Jul 25, 2024
@openshift-ci-robot
Copy link

@perdasilva: This pull request references Jira Issue OCPBUGS-31547. The bug has been updated to no longer refer to the pull request using the external bug tracker.

In response to this:

We've made some significant perf improvements in the last release and this job is challenging to maintain. Disabling it for now, but leaving the bits to potentially serve it if we want to manually configure the job on a customer cluster.

For the microshift manifests, deleting the manifest entirely because there is no cvo for microshift

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants