Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-4.16] OCPBUGS-36450: Can't install operator on 4.15 after uninstalling it on a prior version #809

Merged
merged 2 commits into from
Jul 10, 2024
Merged

[release-4.16] OCPBUGS-36450: Can't install operator on 4.15 after uninstalling it on a prior version #809

merged 2 commits into from
Jul 10, 2024

Conversation

dtfranz
Copy link
Contributor

@dtfranz dtfranz commented Jul 2, 2024 •
edited
Loading

Manual Cherry pick of commits from #758

Awaiting verification for OCPBUGS-32439.
/hold

varshaprasad96 and others added 2 commits July 2, 2024 10:44
@varshaprasad96 @dtfranz
Fix: Ensure jobs without unpack label are considered (#3262)
00690e8 
Signed-off-by: Varsha Prasad Narsing <varshaprasad96@gmail.com>
Upstream-repository: operator-lifecycle-manager
Upstream-commit: 01b44e850bfae0d6775bb7379359b5eaf36f2778
@dtfranz
Unpack Job Creation Failure Test (#3297)
ea03cd9 
Extends an existing unit test to cover the scenario where an old, failed job missing the label added in later OLM versions is not found with the filtered list call, resulting in an 'AlreadyExists' error when the new job is created.

Signed-off-by: Daniel Franz <dfranz@redhat.com>
Upstream-repository: operator-lifecycle-manager
Upstream-commit: 8751ca0212e345a0b7eab452b169d926e7f42437
@openshift-ci-robot openshift-ci-robot added jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Jul 2, 2024
@openshift-ci-robot
Copy link

@dtfranz: This pull request references Jira Issue OCPBUGS-36450, which is invalid:

  • expected Jira Issue OCPBUGS-36450 to depend on a bug targeting a version in 4.17.0 and in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Manual Cherry pick of commits from #758

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from dinhxuanvu and oceanc80 July 2, 2024 17:47
@dtfranz
Copy link
Contributor Author

dtfranz commented Jul 2, 2024

/retest

@dtfranz
Copy link
Contributor Author

dtfranz commented Jul 3, 2024

/jira refresh
/retest

@openshift-ci-robot
Copy link

@dtfranz: This pull request references Jira Issue OCPBUGS-36450, which is invalid:

  • expected Jira Issue OCPBUGS-36450 to depend on a bug targeting a version in 4.17.0 and in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/jira refresh
/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@dtfranz
Copy link
Contributor Author

dtfranz commented Jul 3, 2024

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Jul 3, 2024
@openshift-ci-robot
Copy link

@dtfranz: This pull request references Jira Issue OCPBUGS-36450, which is valid. The bug has been moved to the POST state.

7 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.16.z) matches configured target version for branch (4.16.z)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
  • release note text is set and does not match the template
  • dependent bug Jira Issue OCPBUGS-32439 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
  • dependent Jira Issue OCPBUGS-32439 targets the "4.17.0" version, which is one of the valid target versions: 4.17.0
  • bug has dependents

Requesting review from QA contact:
/cc @kuiwang02

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested a review from kuiwang02 July 3, 2024 16:42
@kuiwang02
Copy link

/label cherry-pick-approved
/label qe-approved

@openshift-ci openshift-ci bot added cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. qe-approved Signifies that QE has signed off on this PR labels Jul 4, 2024
@openshift-ci-robot
Copy link

@dtfranz: This pull request references Jira Issue OCPBUGS-36450, which is valid.

7 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.16.z) matches configured target version for branch (4.16.z)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)
  • release note text is set and does not match the template
  • dependent bug Jira Issue OCPBUGS-32439 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
  • dependent Jira Issue OCPBUGS-32439 targets the "4.17.0" version, which is one of the valid target versions: 4.17.0
  • bug has dependents

Requesting review from QA contact:
/cc @kuiwang02

In response to this:

Manual Cherry pick of commits from #758

Awaiting verification for OCPBUGS-32439.
/hold

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@perdasilva
Copy link
Contributor

/retest

@perdasilva
Copy link
Contributor

/label backport-risk-assessed

@openshift-ci openshift-ci bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Jul 8, 2024
@perdasilva
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 8, 2024
@dtfranz
Copy link
Contributor Author

dtfranz commented Jul 8, 2024

Tests are flaking, we're getting different failures each time :/
/retest

@dtfranz
Copy link
Contributor Author

dtfranz commented Jul 9, 2024

/retest

@joelanford
Copy link
Member

/approve

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jul 9, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dtfranz, joelanford

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 9, 2024
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD ee44d6c and 2 for PR HEAD ea03cd9 in total

@m1kola
Copy link
Contributor

m1kola commented Jul 10, 2024

/retest

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jul 10, 2024

@dtfranz: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit f4eac42 into openshift:release-4.16 Jul 10, 2024
13 checks passed
@openshift-ci-robot
Copy link

@dtfranz: Jira Issue OCPBUGS-36450: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-36450 has been moved to the MODIFIED state.

In response to this:

Manual Cherry pick of commits from #758

Awaiting verification for OCPBUGS-32439.
/hold

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

This PR has been included in build operator-lifecycle-manager-container-v4.16.0-202407101306.p0.gf4eac42.assembly.stream.el9 for distgit operator-lifecycle-manager.
All builds following this will include this PR.

@openshift-merge-robot
Copy link
Contributor

Fix included in accepted release 4.16.0-0.nightly-2024-07-10-162038

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dinhxuanvu dinhxuanvu Awaiting requested review from dinhxuanvu

@oceanc80 oceanc80 Awaiting requested review from oceanc80

@kuiwang02 kuiwang02 Awaiting requested review from kuiwang02

Assignees

@bandrade bandrade

@perdasilva perdasilva

@jianzhangbjz jianzhangbjz

@emmajiafan emmajiafan

@kuiwang02 kuiwang02

@Xia-Zhao-rh Xia-Zhao-rh

@KeenonLee KeenonLee

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. qe-approved Signifies that QE has signed off on this PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.