Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add blank state message when no description #484

Closed
spadgett opened this issue Oct 10, 2017 · 6 comments
Closed

Add blank state message when no description #484

spadgett opened this issue Oct 10, 2017 · 6 comments
Assignees
@rhamilto
Labels
area/usability priority/P3

Comments

@spadgett
Copy link
Member

This shouldn't be common, but I'm assuming we want a blank state message here.

@openshift/team-ux-review ?

openshift web console 2017-10-10 12-30-35
@ncameronbritt
Copy link

I would think something like "No description provided for this service," so that it doesn't look like something is wrong.

@rhamilto
Copy link
Member

rhamilto commented Oct 11, 2017 •
edited

I eliminated "for this service" because the item could not be a service. Yea/nay?

screen shot 2017-10-11 at 11 02 22 am
screen shot 2017-10-11 at 11 03 01 am
screen shot 2017-10-11 at 11 14 43 am
screen shot 2017-10-11 at 11 15 00 am

@spadgett
Copy link
Member Author

Looks good to me. 3rd screenshot seems like a bug, though, or were you just putting it in to test?

@beanh66
Copy link
Member

beanh66 commented Oct 11, 2017

@rhamilto Looks good to me!

@rhamilto
Copy link
Member

Looks good to me. 3rd screenshot seems like a bug, though, or were you just putting it in to test?

Yup. Good eye, @spadgett!

@rhamilto rhamilto mentioned this issue Oct 11, 2017
Merged
@rhamilto
Copy link
Member

Looks good to me. 3rd screenshot seems like a bug, though, or were you just putting it in to test?

I should add that third screenshot is the scenario where the service has a longDescription but not a "short" one.

@rhamilto rhamilto reopened this Oct 13, 2017
@rhamilto rhamilto mentioned this issue Oct 13, 2017
Merged
openshift-merge-robot added a commit to openshift/origin-web-console that referenced this issue Oct 13, 2017
@openshift-merge-robot
Merge pull request #2264 from rhamilto/issue-484
9930f0c 
Automatic merge from submit-queue.

Adding default message if no description is provided

Fixes openshift/origin-web-catalog#484
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rhamilto rhamilto

Labels
area/usability priority/P3
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@rhamilto @spadgett @ncameronbritt @beanh66