-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update angular-patternfly dependency to "at least" syntax #408
Update angular-patternfly dependency to "at least" syntax #408
Conversation
We should at least lock down to version 4.x. We don't know if this will work with new major versions. |
d2924fb
to
a5ec19e
Compare
Just changed it to: |
Need to update bower.json as well |
a5ec19e
to
4d321b5
Compare
Curious why its in both |
So that downstream projects can use either npm or bower |
I wonder if we should update some of the other dependencies like this as well. |
origin-web-common isn't a problem until we cut a >=0.1.0 release. I think for now it's OK and we can reevaluate later. origin-web-common changes often need to happen in step with catalog changes, so it might be better to lock versions honestly. |
Ok works for me. This one is needed to resolve the issue bumping |
>
for angular-patternfly.gitignore
We are using
~
right now, which allows for a range in the patch. I think we should use>
.Perhaps
>=
would be better:"angular-patternfly": ">=4.3.0"
as we should be able to expect future minor changes to work as well. We can add a limit if it makes sense:
"angular-patternfly": ">=4.3.0 <5.0.0"
This should clarify that
openshift-web-console
is the source of truth & simplify bumping the dependencies. It does assumesemver
is followed closely & breaking changes will not be introduced without a major version bump.@spadgett @jeff-phillips-18 ?
Relevant for this PR