Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update angular-patternfly dependency to "at least" syntax #408

Merged

Conversation

benjaminapetersen
Copy link
Contributor

  • use > for angular-patternfly
  • add DS_Store to .gitignore

We are using ~ right now, which allows for a range in the patch. I think we should use >.

Perhaps >= would be better:

"angular-patternfly": ">=4.3.0"

as we should be able to expect future minor changes to work as well. We can add a limit if it makes sense:

"angular-patternfly": ">=4.3.0 <5.0.0"

This should clarify that openshift-web-console is the source of truth & simplify bumping the dependencies. It does assume semver is followed closely & breaking changes will not be introduced without a major version bump.

@spadgett @jeff-phillips-18 ?

Relevant for this PR

@spadgett
Copy link
Member

spadgett commented Aug 30, 2017

We should at least lock down to version 4.x. We don't know if this will work with new major versions.

@benjaminapetersen
Copy link
Contributor Author

Just changed it to: "angular-patternfly": ">=4.7.1 <5.0.0",

@spadgett
Copy link
Member

Need to update bower.json as well

@benjaminapetersen
Copy link
Contributor Author

Curious why its in both package.json and bower.json? Updating now.

@spadgett
Copy link
Member

So that downstream projects can use either npm or bower

@benjaminapetersen
Copy link
Contributor Author

I wonder if we should update some of the other dependencies like this as well. origin-web-common is probably a good candidate. I tend to trust jQuery and lodash not to break unexpectedly (per above, just passing the real responsibility to specify exact versions to origin-web-console).

@spadgett
Copy link
Member

origin-web-common isn't a problem until we cut a >=0.1.0 release. I think for now it's OK and we can reevaluate later.

origin-web-common changes often need to happen in step with catalog changes, so it might be better to lock versions honestly.

@benjaminapetersen
Copy link
Contributor Author

Ok works for me.

This one is needed to resolve the issue bumping angular-patternfly for fixing track by in the web-console notification drawer PR. openshift/origin-web-console#1988

@spadgett spadgett merged commit 6385124 into openshift:master Aug 30, 2017
@benjaminapetersen benjaminapetersen deleted the bpeterse/alt-ng-pf-dependency branch August 30, 2017 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants