Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide items with a 'hidden' tag #480

Merged
merged 1 commit into from
Oct 10, 2017
Merged

Conversation

spadgett
Copy link
Member

@spadgett spadgett commented Oct 10, 2017

@openshift-ci-robot openshift-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 10, 2017
@spadgett
Copy link
Member Author

Hm, not sure what is wrong in Travis:

10 10 2017 13:58:16.953:INFO [Firefox 49.0.0 (Linux 0.0.0)]: Connected on socket MN95d2HHaPVwQTsnAAAA with id 80085566
Firefox 49.0.0 (Linux 0.0.0) ERROR
  TypeError: __webpack_require__.i(...) is not a function
  at test/test-bundle.ts:9
Firefox 49.0.0 (Linux 0.0.0): Executed 0 of 0 ERROR (2.908 secs / 0 secs)

@dtaylor113
Copy link
Contributor

@spadgett, just rebased origin-web-catalog, hack clean & install deps, npm test. Passed 40 out of 40. Looks like Travis failed with the 'executed 0 of 0' issue which we initially fixed by using FireFox v49. Not sure what's wrong with Travis.

@spadgett
Copy link
Member Author

Closing and reopening to force Travis to retest.

@spadgett spadgett closed this Oct 10, 2017
@spadgett spadgett reopened this Oct 10, 2017
@dtaylor113
Copy link
Contributor

Just set

node --version
v4.8.3
npm --version
2.15.11

Now I'm getting the unit test failures seen in Travis.
cc @jeff-phillips-18

@jeff-phillips-18
Copy link
Member

Can we update the npm version being used by travis?

@dtaylor113
Copy link
Contributor

@spadgett, why is Travis using such an old version of node? Can we update it to use node v5?

@spadgett
Copy link
Member Author

Trying node 6 in #482

@openshift-ci-robot openshift-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 10, 2017
@spadgett
Copy link
Member Author

Removed the provider annotation from this PR since there's still some debate on the name. I'll open a follow up for that.

@spadgett spadgett changed the title [WIP] Hide items with a 'hidden' tag Hide items with a 'hidden' tag Oct 10, 2017
@openshift-ci-robot openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 10, 2017
@spadgett
Copy link
Member Author

Opened #487 for provider display name

@jeff-phillips-18 PTAL

@spadgett spadgett merged commit 122730d into openshift:master Oct 10, 2017
@spadgett spadgett deleted the hidden-items branch October 10, 2017 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants