NotificationsService memory leak and issues

[dtaylor113]

The notification service leaks memory because it keeps all notifications even after they're no longer displayed.

Also, isNotificationVisible should return false if it's drawer only. The intended use of this function was to avoid showing two toast notifications.

Some additional comments by @spadgett:

"I think it would be better to just not keep an array of notifications. Notification service addNotification just broadcasts a message and is done then the toasts notification component can make sure it's not showing the same one twice and drawer tracks current notifications and if they've been cleared itself"

Another issue is that there is now way for user to 'restore' permanently hidden notifications.

[benjaminapetersen]

I wonder if we can consolidate some tracking as well, EventsService (in web-console) is also tracking & storing info in localStorage. Events & Notifications are different objects, so it might be fine, but worth a thought.

[openshift-bot]

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

[openshift-bot]

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

[openshift-bot]

Stale issues rot after 30d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle rotten
/remove-lifecycle stale

[openshift-bot]

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen.
Mark the issue as fresh by commenting /remove-lifecycle rotten.
Exclude this issue from closing again by commenting /lifecycle frozen.

/close

[openshift-ci-robot]

@openshift-bot: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen.
Mark the issue as fresh by commenting /remove-lifecycle rotten.
Exclude this issue from closing again by commenting /lifecycle frozen.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.