-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NotificationsService memory leak and issues #220
Comments
I wonder if we can consolidate some tracking as well, |
Issues go stale after 90d of inactivity. Mark the issue as fresh by commenting If this issue is safe to close now please do so with /lifecycle stale |
Issues go stale after 90d of inactivity. Mark the issue as fresh by commenting If this issue is safe to close now please do so with /lifecycle stale |
Stale issues rot after 30d of inactivity. Mark the issue as fresh by commenting If this issue is safe to close now please do so with /lifecycle rotten |
Rotten issues close after 30d of inactivity. Reopen the issue by commenting /close |
@openshift-bot: Closing this issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
The notification service leaks memory because it keeps all notifications even after they're no longer displayed.
Also, isNotificationVisible should return false if it's drawer only. The intended use of this function was to avoid showing two toast notifications.
Some additional comments by @spadgett:
"I think it would be better to just not keep an array of notifications. Notification service
addNotification
just broadcasts a message and is done then the toasts notification component can make sure it's not showing the same one twice and drawer tracks current notifications and if they've been cleared itself"Another issue is that there is now way for user to 'restore' permanently hidden notifications.
The text was updated successfully, but these errors were encountered: