Update BindService for binding parameters #163
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
spadgett
force-pushed
the
bind-service-updates
branch
2 times, most recently
from
9b71f2c
to
e3049e9
Compare
spadgett
force-pushed
the
bind-service-updates
branch
from
e3049e9
to
b500f54
Compare
jeff-phillips-18
approved these changes
Sep 1, 2017
|
@spadgett Is this ready to go or still WIP? |
Merged
spadgett
force-pushed
the
bind-service-updates
branch
from
b500f54
to
e25a749
Compare
spadgett
changed the title
|
@jeff-phillips-18 This should be ready. One small change to remove an unused function. |
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://trello.com/c/Sws4p5jU