Avoid multiple selfsubjectrulesreviews requests #165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
23 tasks
If a selfsubjectrulesreviews for a project is already in flight, don't request the rules a second time.
spadgett
force-pushed
the
avoid-multiple-rules-requests
branch
from
b6e60df
to
bda988e
Compare
jeff-phillips-18
approved these changes
Aug 31, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a selfsubjectrulesreviews for a project is already in flight, don't request the rules a second time.
Needed to avoid two requests with the pending navigation changes, openshift/origin-web-console#1932
@jeff-phillips-18 PTAL
@rhamilto FYI