Update notifications with id and timestamp #170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spadgett
reviewed
Sep 5, 2017
| @@ -18,6 +18,9 @@ angular.module('openshiftCommonUI').provider('NotificationsService', function() | |||
| }; | |||
|
|
|||
| var addNotification = function (notification) { | |||
| notification.id = notification.id || _.uniqueId('notification-'); | |||
| // This format matches timestamp of API objects | |||
| notification.timestamp = moment.parseZone(new Date()).utc().format(); | |||
There was a problem hiding this comment.
I think just
new Date().toISOString();does what we want, then we don't need to add moment.js to common
There was a problem hiding this comment.
True. lets do that.
benjaminapetersen
force-pushed
the
bpeterse/notification-update
branch
3 times, most recently
from
42844a8
to
bc2c28b
Compare
|
Just updated the filters as well to take the api object type (Normal, Warning). |
spadgett
reviewed
Sep 5, 2017
| @@ -18,6 +18,10 @@ angular.module('openshiftCommonUI').provider('NotificationsService', function() | |||
| }; | |||
|
|
|||
| var addNotification = function (notification) { | |||
| notification.id = notification.id || _.uniqueId('notification-'); | |||
| // This format matches timestamp of API objects | |||
| //notification.timestamp = moment.parseZone(new Date()).utc().format(); | |||
benjaminapetersen
force-pushed
the
bpeterse/notification-update
branch
from
bc2c28b
to
284898a
Compare
spadgett
approved these changes
Sep 6, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per this comment in PR 2001 in origin-web-console.
@spadgett @jeff-phillips-18