Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adopt new service catalog resource names #182

Merged

Conversation

spadgett
Copy link
Member

@spadgett spadgett commented Sep 11, 2017

https://trello.com/c/y1lbFrbp

Instance -> ServiceInstance
Binding -> ServiceInstanceCredential

Instance -> ServiceInstance
Binding -> ServiceInstanceCredential
@spadgett
Copy link
Member Author

Rebased

@spadgett spadgett changed the title [WIP] Adopt new service catalog resource names Adopt new service catalog resource names Sep 13, 2017
@benjaminapetersen benjaminapetersen merged commit 8862f16 into openshift:master Sep 14, 2017
@spadgett spadgett deleted the service-catalog-api-changes branch September 14, 2017 13:48
@benjaminapetersen
Copy link
Contributor

Worth a conversation about a follow-on, do we want to update our internal vars & service names as well:

// now a credentialResource?
var bindingResource = {
  group: 'servicecatalog.k8s.io',
  resource: 'serviceinstancecredentials'
};		    

// CredentialService?
angular.module("openshiftCommonServices")
  .service("BindingService",

// etc.

Could prob make a tech debt issue

@spadgett
Copy link
Member Author

Good question. We still call it "Binding" in the UI, and we will eventually make pod presets to bind to apps as well.

@benjaminapetersen
Copy link
Contributor

No strong opinion then, unless we update to "Credentials" in the UI at some point.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants