Fix API_PREFERRED_VERSIONS.autoscaling to horizontalpodautoscalers #201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spadgett
reviewed
Sep 25, 2017
dist/origin-web-common.js
Outdated
| @@ -1425,11 +1425,11 @@ angular.module('openshiftCommonUI') | |||
|
|
|||
| angular.module('openshiftCommonServices') | |||
| .constant('API_PREFERRED_VERSIONS', { | |||
| autoscaling: {group: 'autoscaling', resource: 'horizontalpodautoscalers' }, | |||
| horizontalpodautoscalers: {group: 'autoscaling', resource: 'horizontalpodautoscalers' }, | |||
There was a problem hiding this comment.
lol not alpha as in api, alpha as in alphabetize. I will fix :)
benjaminapetersen
force-pushed
the
bpetersen/trello/api-groups/horizontalpodautoscalers
branch
from
ad8d705
to
b8afcba
Compare
|
Updated |
benjaminapetersen
force-pushed
the
bpetersen/trello/api-groups/horizontalpodautoscalers
branch
from
b8afcba
to
676689e
Compare
|
Sneaking in |
Merged
Might want to add |
benjaminapetersen
force-pushed
the
bpetersen/trello/api-groups/horizontalpodautoscalers
branch
from
676689e
to
674ae5d
Compare
|
will do. |
This was referenced Sep 25, 2017
Merged
|
@spadgett thoughts on this? Could get 2-3 of the larger PRs merged in today then. |
spadgett
approved these changes
Sep 26, 2017
benjaminapetersen
deleted the
bpetersen/trello/api-groups/horizontalpodautoscalers
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mistake naming this version
@spadgett