-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix API_PREFERRED_VERSIONS.autoscaling to horizontalpodautoscalers #201
Fix API_PREFERRED_VERSIONS.autoscaling to horizontalpodautoscalers #201
Conversation
dist/origin-web-common.js
Outdated
@@ -1425,11 +1425,11 @@ angular.module('openshiftCommonUI') | |||
|
|||
angular.module('openshiftCommonServices') | |||
.constant('API_PREFERRED_VERSIONS', { | |||
autoscaling: {group: 'autoscaling', resource: 'horizontalpodautoscalers' }, | |||
horizontalpodautoscalers: {group: 'autoscaling', resource: 'horizontalpodautoscalers' }, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: alpha
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lol not alpha
as in api, alpha
as in alphabetize. I will fix :)
ad8d705
to
b8afcba
Compare
Updated |
b8afcba
to
676689e
Compare
Sneaking in |
Might want to add |
676689e
to
674ae5d
Compare
will do. |
@spadgett thoughts on this? Could get 2-3 of the larger PRs merged in today then. |
Mistake naming this version
@spadgett