add ability to "disable" form validity #203
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeff-phillips-18
approved these changes
Sep 27, 2017
spadgett
requested changes
Sep 27, 2017
| return; | ||
| } | ||
| ctrl.$setValidity('oscUnique', disabled); | ||
| }); |
There was a problem hiding this comment.
I'd just refer to $scope.oscUniqueDisabled everywhere so we don't have two variables tracking the same value that could get out of sync. I think this could be a one-liner.
$scope.$watch('oscUniqueDisabled', function() {
ctrl.$setValidity('oscUnique', $scope.oscUniqueDisabled || isValid);
});| }, | ||
| require: 'ngModel', | ||
| link: function($scope, $elem, $attrs, ctrl) { | ||
| var list = []; | ||
| var disabled = false; | ||
| var isValid = true; |
There was a problem hiding this comment.
I suggest isUnique here. It's technically valid if disabled even when not unique, so I think isUnique is more accurate.
| // if disabled, skip validation, return true | ||
| if(disabled) { | ||
| ctrl.$setValidity('oscUnique', disabled); | ||
| return disabled; |
There was a problem hiding this comment.
Isn't this supposed to return the input value, not true?
https://docs.angularjs.org/api/ng/type/ngModel.NgModelController#$parsers
I think this can be
ctrl.$parsers.unshift(function(value) {
isValid = !_.includes(list, value);
ctrl.$setValidity('oscUnique', $scope.oscUniqueDisabled || isValid);
return value;
});You could pull the $setValidity line into its own function above so it's not repeated.
var isUnique = true;
var updateValiditity = function() {
ctrl.$setValidity('oscUnique', $scope.oscUniqueDisabled || isUnique);
};
$scope.$watch('oscUniqueDisabled', updateValidity);
ctrl.$parsers.unshift(function(value) {
isUnique = !_.includes(list, value);
updateValidity();
return value;
});
juanvallejo
force-pushed
the
jvallejo/add-osc-unique-disabled-attr
branch
from
49936dc
to
844fb58
Compare
|
@spadgett thanks for the feedback, review comments addressed |
spadgett
approved these changes
Sep 28, 2017
openshift-merge-robot
added a commit
to openshift/origin-web-console
that referenced
this pull request
Oct 13, 2017
…rwrite-option Automatic merge from submit-queue. add "overwrite" option to attachPVC view Depends on: openshift/origin-web-common#203 Fixes #2045 Work in progress. Just wanted to begin gathering feedback. Will post images. cc @spadgett @benjaminapetersen
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Required by: openshift/origin-web-console#2176
Adds ability to disable form validity based on value of a model.