-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Using truncate-long-text directive to truncate with see all link for long service descriptions. #214
Using truncate-long-text directive to truncate with see all link for long service descriptions. #214
Conversation
@@ -3,7 +3,11 @@ | |||
styled directly in origin-web-common. `truncated-content` is used by | |||
origin-web-console in certain contexts. | |||
--> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add a comment explaining highlightKeywords and linkify are mutually exclusive options.
<span ng-if="!linkify || (highlightKeywords | size)" ng-bind-html="content | highlightKeywords : keywords" class="truncated-content"></span> | ||
<span ng-if="linkify && !(highlightKeywords | size)" ng-bind-html="content | linkify : '_blank'" class="truncated-content"></span> | ||
</span> | ||
<!-- To avoid truncating in middle of a link, we only apply linkify to expanded content --> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
<!-- To avoid truncating in middle of a link, we only apply linkify to expanded content -->
<!-- To avoid truncating in middle of a link, we only optionally apply linkify to expanded content -->
…long service descriptions. Remove prettify-json from directive since it's no longer used. Add linkify to description link, but only when in expanded state.
65da8e0
to
2d76f24
Compare
@rhamilto pr updated and I'll open a WIP in orign-web-console for the related changes |
Remove prettify-json from directive since it's no longer used.
Add linkify to description link, but only when in expanded state.
Fixes openshift/origin-web-console#2072