Skip to content

Commit

Permalink
Do not show binding parameters on the overview page
Browse files Browse the repository at this point in the history
  • Loading branch information
jeff-phillips-18 committed Oct 20, 2017
1 parent f127c70 commit 156555f
Show file tree
Hide file tree
Showing 8 changed files with 10 additions and 6 deletions.
1 change: 1 addition & 0 deletions app/scripts/directives/serviceInstanceBindings.js
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ angular.module('openshiftConsole').component('serviceInstanceBindings', {
],
controllerAs: '$ctrl',
bindings: {
isOverview: '<?',
showHeader: '<?',
project: '<',
bindings: '<',
Expand Down
2 changes: 1 addition & 1 deletion app/views/directives/_service-binding.html
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ <h3>
View Secret
</a>
</div>
<div class="service-binding-parameters" ng-if="$ctrl.bindParameterSchema.properties">
<div class="service-binding-parameters" ng-if="!$ctrl.isOverview && $ctrl.bindParameterSchema.properties">
<span class="parameters-heading">Parameters</span>
<a href="" ng-click="$ctrl.toggleShowParameterValues()" role="button">
{{$ctrl.showParameterValues ? 'Hide Values' : 'Reveal Values'}}
Expand Down
1 change: 1 addition & 0 deletions app/views/directives/service-instance-bindings.html
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
<h3 ng-if="$ctrl.showHeader">Bindings</h3>
<service-binding
ng-repeat="binding in $ctrl.bindings track by (binding | uid)"
is-overview="$ctrl.isOverview"
namespace="binding.metadata.namespace"
binding="binding"
ref-api-object="$ctrl.serviceInstance">
Expand Down
1 change: 1 addition & 0 deletions app/views/overview/_service-instance-row.html
Original file line number Diff line number Diff line change
Expand Up @@ -152,6 +152,7 @@ <h3>
<div ng-if="row.isBindable || (row.bindings | size)">
<div class="section-title">Bindings</div>
<service-instance-bindings
is-overview="true"
project="row.state.project"
bindings="row.bindings"
service-instance="row.apiObject"
Expand Down
1 change: 1 addition & 0 deletions dist/scripts/scripts.js
Original file line number Diff line number Diff line change
Expand Up @@ -10439,6 +10439,7 @@ templateUrl: "views/directives/resource-service-bindings.html"
controller: [ "$filter", "APIService", "BindingService", ServiceInstanceBindings ],
controllerAs: "$ctrl",
bindings: {
isOverview: "<?",
showHeader: "<?",
project: "<",
bindings: "<",
Expand Down
6 changes: 3 additions & 3 deletions dist/scripts/templates.js
Original file line number Diff line number Diff line change
Expand Up @@ -5679,7 +5679,7 @@ angular.module('openshiftConsoleTemplates', []).run(['$templateCache', function(
"View Secret\n" +
"</a>\n" +
"</div>\n" +
"<div class=\"service-binding-parameters\" ng-if=\"$ctrl.bindParameterSchema.properties\">\n" +
"<div class=\"service-binding-parameters\" ng-if=\"!$ctrl.isOverview && $ctrl.bindParameterSchema.properties\">\n" +
"<span class=\"parameters-heading\">Parameters</span>\n" +
"<a href=\"\" ng-click=\"$ctrl.toggleShowParameterValues()\" role=\"button\">\n" +
"{{$ctrl.showParameterValues ? 'Hide Values' : 'Reveal Values'}}\n" +
Expand Down Expand Up @@ -9223,7 +9223,7 @@ angular.module('openshiftConsoleTemplates', []).run(['$templateCache', function(
$templateCache.put('views/directives/service-instance-bindings.html',
"<div ng-if=\"$ctrl.bindable || ($ctrl.bindings | size)\">\n" +
"<h3 ng-if=\"$ctrl.showHeader\">Bindings</h3>\n" +
"<service-binding ng-repeat=\"binding in $ctrl.bindings track by (binding | uid)\" namespace=\"binding.metadata.namespace\" binding=\"binding\" ref-api-object=\"$ctrl.serviceInstance\">\n" +
"<service-binding ng-repeat=\"binding in $ctrl.bindings track by (binding | uid)\" is-overview=\"$ctrl.isOverview\" namespace=\"binding.metadata.namespace\" binding=\"binding\" ref-api-object=\"$ctrl.serviceInstance\">\n" +
"</service-binding>\n" +
"<div ng-if=\"$ctrl.bindable\">\n" +
"<a href=\"\" ng-click=\"$ctrl.createBinding()\" role=\"button\">\n" +
Expand Down Expand Up @@ -12638,7 +12638,7 @@ angular.module('openshiftConsoleTemplates', []).run(['$templateCache', function(
"</div>\n" +
"<div ng-if=\"row.isBindable || (row.bindings | size)\">\n" +
"<div class=\"section-title\">Bindings</div>\n" +
"<service-instance-bindings project=\"row.state.project\" bindings=\"row.bindings\" service-instance=\"row.apiObject\" service-class=\"row.serviceClass\" service-plan=\"row.servicePlan\">\n" +
"<service-instance-bindings is-overview=\"true\" project=\"row.state.project\" bindings=\"row.bindings\" service-instance=\"row.apiObject\" service-class=\"row.serviceClass\" service-plan=\"row.servicePlan\">\n" +
"</service-instance-bindings>\n" +
"</div>\n" +
"</div>\n" +
Expand Down
2 changes: 1 addition & 1 deletion dist/scripts/vendor.js
Original file line number Diff line number Diff line change
Expand Up @@ -79232,7 +79232,7 @@ var u = this;
this.ctrl = this, this.configChanged = !0, this.secrets = [], this.clearValidityWatcher = function() {
u.validityWatcher && (u.validityWatcher(), u.validityWatcher = void 0), u.ctrl.reviewStep.allowed = !1;
}, this.showPlan = function() {
u.clearValidityWatcher(), u.ctrl.configPageShown = !1;
u.clearValidityWatcher(), u.ctrl.configPageShown = !1, u.configStep.hidden ? u.ctrl.nextTitle = "Update" : u.ctrl.nextTitle = "Next >", u.planStep.valid = u.ctrl.selectedPlan !== u.originalPlan || !u.configStep.hidden;
}, this.showConfig = function() {
u.clearValidityWatcher(), u.ctrl.configPageShown = !0, u.configStep.valid = r.get(u.ctrl, "forms.orderConfigureForm.$valid") && u.configChanged, u.reviewStep.allowed = u.configStep.valid, u.validityWatcher = u.$scope.$watch("$ctrl.forms.orderConfigureForm.$valid", function(e, t) {
u.configStep.valid = e && u.configChanged, u.reviewStep.allowed = u.configStep.valid;
Expand Down
2 changes: 1 addition & 1 deletion dist/styles/main.css

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit 156555f

Please sign in to comment.