Skip to content

Commit

Permalink
Merge pull request #2382 from rhamilto/mobile-vert-nav-transition
Browse files Browse the repository at this point in the history
Automatic merge from submit-queue.

Only transition vertical nav at mobile on show

As a follow on to #2381, it feels better to me if the vertical nav at mobile only transitions on show.  This way the vertical nav goes away immediately on clicking a nav item rather than lingering around as it transitions off the screen.
  • Loading branch information
openshift-merge-robot authored Oct 25, 2017
2 parents d912700 + a7c53d1 commit 68b29c4
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 3 deletions.
3 changes: 2 additions & 1 deletion app/styles/_vertical-nav.less
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
display: none;
}
.has-project-bar & {
transition: width .1s ease-in-out, left .1s ease-in-out;
transition: width .1s ease-in-out;
top: (@navbar-os-header-height-mobile + @project-bar-height-mobile);
@media(min-width: @screen-sm-min) {
display: block;
Expand Down Expand Up @@ -99,6 +99,7 @@
&.show-mobile-nav {
box-shadow: 2px 0 3px rgba(3,3,3,.15);
left: 0;
transition: left .1s ease-in-out;
}
.nav-pf-secondary-nav {
background: @nav-pf-vertical-active-bg-color;
Expand Down
4 changes: 2 additions & 2 deletions dist/styles/main.css

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit 68b29c4

Please sign in to comment.