Skip to content

Commit

Permalink
Make close notification link accessible
Browse files Browse the repository at this point in the history
The link was missing an `href` and could not be triggered using
the keyboard.
  • Loading branch information
spadgett committed Sep 18, 2017
1 parent b4196ee commit 8d9ea89
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion app/views/directives/notifications/notification-body.html
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
ng-click="$ctrl.customScope.markRead(notification)">
<a
class="pull-right"
tabindex="0"
href=""
ng-click="$ctrl.customScope.clear(notification, $index, notificationGroup)">
<span class="sr-only">Clear notification</span>
<span
Expand Down
2 changes: 1 addition & 1 deletion dist/scripts/templates.js
Original file line number Diff line number Diff line change
Expand Up @@ -7570,7 +7570,7 @@ angular.module('openshiftConsoleTemplates', []).run(['$templateCache', function(

$templateCache.put('views/directives/notifications/notification-body.html',
"<div class=\"drawer-pf-notification-inner\" tabindex=\"0\" ng-click=\"$ctrl.customScope.markRead(notification)\">\n" +
"<a class=\"pull-right\" tabindex=\"0\" ng-click=\"$ctrl.customScope.clear(notification, $index, notificationGroup)\">\n" +
"<a class=\"pull-right\" href=\"\" ng-click=\"$ctrl.customScope.clear(notification, $index, notificationGroup)\">\n" +
"<span class=\"sr-only\">Clear notification</span>\n" +
"<span ng-if=\"notification.event\" aria-hidden=\"true\" class=\"pull-left pficon pficon-close\"></span>\n" +
"</a>\n" +
Expand Down

0 comments on commit 8d9ea89

Please sign in to comment.